Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use any form on preference center #6404

Open
wants to merge 22 commits into
base: staging
from

Conversation

Projects
6 participants
@kuzmany
Copy link
Contributor

kuzmany commented Jul 31, 2018

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #6397
BC breaks?
Deprecations?

Description:

Prefs page center wrap to form all source, from <body>
This PR remove it and add support to form just wrap prefs slots/tokens. This change allow use Unsubscribe feedback form /any forms on that page.

Steps to reproduce the bug:

  1. Create a form
  2. Create a landing page, set it as the preference center. In the builder add some bloc form the pref center and add the form previously created with the token {form=ID}
  3. Create an email, assign the pref center to this email.
  4. Shoot the email
  5. When you received the email, click on the unsubscribe link. You should land on the pref center.
  6. Submit the form you integrated.
  7. Check the form result and see that there is no submission.

Steps to test this PR:

  1. Repeat all steps
  2. Both form should submit

DOM HTML with 2 forms separately

image

@kuzmany kuzmany added Bug WIP labels Jul 31, 2018

kuzmany added some commits Jul 31, 2018

@kuzmany kuzmany added Ready To Test and removed WIP labels Jul 31, 2018

@kuzmany kuzmany added this to the 2.15.0 milestone Jul 31, 2018

@npracht npracht added the Code Review label Aug 1, 2018

@npracht npracht modified the milestones: 2.15.0, 2.14.2 Sep 5, 2018

@npracht

npracht approved these changes Oct 2, 2018

Copy link
Member

npracht left a comment

Tested for few days and it is working properly.
Please solve the conflict @kuzmany

@escopecz escopecz added this to Tested Once in Testing 2.14.2 Oct 2, 2018

@escopecz

This comment has been minimized.

Copy link
Member

escopecz commented Oct 2, 2018

@kuzmany please deal with the conflicts

@escopecz escopecz moved this from Tested Once to Pending Feedback in Testing 2.14.2 Oct 2, 2018

kuzmany added some commits Oct 4, 2018

@kuzmany

This comment has been minimized.

Copy link
Contributor Author

kuzmany commented Oct 4, 2018

Resolved

@kuzmany kuzmany moved this from Pending Feedback to Tested Once in Testing 2.14.2 Oct 4, 2018

@kuzmany kuzmany moved this from Pending Feedback to Tested Once in Testing 2.14.2 Oct 15, 2018

@escopecz escopecz modified the milestones: 2.14.2, 2.15.0 Oct 16, 2018

@npracht npracht added this to Tested once in Testing 2.15.0 Oct 16, 2018

@Woeler Woeler requested a review from escopecz Nov 11, 2018

@escopecz escopecz self-assigned this Nov 12, 2018

@escopecz

This comment has been minimized.

Copy link
Member

escopecz commented Nov 25, 2018

@kuzmany there are conflicts again. Please resolve.

@escopecz escopecz moved this from Tested once to Pending feedback in Testing 2.15.0 Nov 25, 2018

@kuzmany kuzmany removed the Has Conflicts label Nov 26, 2018

@mleffler mleffler moved this from Pending feedback to Tested once in Testing 2.15.0 Nov 27, 2018

@npracht

This comment has been minimized.

Copy link
Member

npracht commented Nov 29, 2018

@escopecz everything fine for you now ?

@escopecz

This comment has been minimized.

Copy link
Member

escopecz commented Dec 3, 2018

It still doesn't seem to be working for me. The preference center form is not working. The form embeded with {form=ID} is working fine. When I view the source code there is only one <form/> tag. The preference center form is missing it and so it never submits.

@escopecz escopecz moved this from Tested once to Pending feedback in Testing 2.15.0 Dec 3, 2018

@Woeler Woeler removed this from Pending feedback in Testing 2.15.0 Dec 5, 2018

@Woeler Woeler modified the milestones: 2.15.0, 2.15.1 Dec 5, 2018

@heathdutton heathdutton added this to Code Review (2 required) in Mautic 2 Dec 6, 2018

@npracht npracht moved this from Code Review (2 required) to Changes Requested / Review in Mautic 2 Jan 3, 2019

@kuzmany

This comment has been minimized.

Copy link
Contributor Author

kuzmany commented Jan 7, 2019

@escopecz I tested it and works for me
I use custom prefs center, insert Prefs tokens + {form} tag.
Both works.

image

@alanhartless alanhartless added this to Discussion in 2.15.1 Jan 14, 2019

@alanhartless alanhartless removed this from the 2.15.1 milestone Mar 11, 2019

@alanhartless alanhartless removed this from Discussion in 2.15.1 Mar 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.