Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Preference Center option to segments #6410

Merged
merged 8 commits into from Nov 15, 2018

Conversation

Projects
5 participants
@kuzmany
Copy link
Contributor

kuzmany commented Aug 1, 2018

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #5658
BC breaks?
Deprecations?

Description:

This PR added new option to segments - Editable by contact. This option allow select segments which will show in contact's preference center. Based on Alan's comments here #5658 (comment)
This PR added also migration and set that new option with same values as Public option.

image

Steps to test this PR:

  1. Apply PR and run php app/console doctrine:migrations:migrate
  2. Go to segments and see segments with new option Editable by contact. Set some segments as Editable by contact
  3. Go to preferences center in Mautic for contact and add all segments to contact.
  4. Send email with unsubscribe link.
  5. Open contact's preference center and see just segments with marked as editable
  6. Change it and go to contact's profile in Mautic and see If just selected segments were removed.

kuzmany added some commits Aug 1, 2018

@kuzmany kuzmany added Ready To Test and removed WIP labels Aug 1, 2018

@kuzmany kuzmany added this to the 2.15.0 milestone Aug 1, 2018

@npracht

This comment has been minimized.

Copy link
Member

npracht commented Aug 2, 2018

The label is very weird to me. What about Available in Preference Center ?

@heathdutton

This comment has been minimized.

Copy link
Member

heathdutton commented Aug 7, 2018

I'm not sure this is working as designed.
screen shot 2018-08-07 at 11 58 39 am
https://mautibox.com/6410/s/contacts/view/1

Perhaps these switches could get some tooltips for a slightly more detailed explanation? You know, for my friend, who might not get it. Not me, I totally get it... cough

@kuzmany

This comment has been minimized.

Copy link
Contributor Author

kuzmany commented Aug 8, 2018

@heathdutton

I've added tooltips.

It's little confused. Read conversations and alan's answer #5658 (comment)

Public option - can Mautic user assign segment to contact in Mautic, and also use with campaign condition/action etc.
Available in Preference Center - can change assignment by contact in his preference center (unsubscribe link in email)

Maybe native speaker can get better explanation,

@npracht npracht added this to To do in Testing 2.15.0 Oct 16, 2018

@npracht npracht self-assigned this Nov 7, 2018

@Enc3phale
Copy link
Contributor

Enc3phale left a comment

Tested, work as expected.
Need conflict resolving before merge.

@@ -192,12 +192,12 @@ public function buildForm(FormBuilderInterface $builder, array $options)
'lead_lists',
'leadlist_choices',
[
'global_only' => true,

This comment has been minimized.

@Enc3phale

Enc3phale Nov 14, 2018

Contributor

Is there a reason that this line is removed?

This comment has been minimized.

@kuzmany

kuzmany Nov 14, 2018

Author Contributor

Because we have new option preference_center_only
global_only will make sense If we will use in future permission for segmetns (same like in reports - public report)

'preference_center_only' => $options['preference_center_only'],

@npracht
Copy link
Member

npracht left a comment

Tested in production environnement for several weeks and it works properly. Tested again right now, still good.

Just the conflict to solve and question from @Enc3phale to tag ready to commit.

@kuzmany kuzmany removed the Has Conflicts label Nov 14, 2018

@kuzmany

This comment has been minimized.

Copy link
Contributor Author

kuzmany commented Nov 14, 2018

@npracht resolved, but staging has changes from another PR, then I suppose to re-test

@@ -123,8 +123,7 @@ public function configureOptions(OptionsResolver $resolver)
$resolver->setRequired(['channels']);
$resolver->setDefaults(
[
'public_view' => false,
'preference_center_only' => false,

This comment has been minimized.

@Enc3phale

Enc3phale Nov 14, 2018

Contributor

Retested, we need this line 'preference_center_only' => false, otherwise we have 500 on unsubscribe page.

@kuzmany kuzmany added the WIP label Nov 14, 2018

@kuzmany kuzmany removed the WIP label Nov 14, 2018

@npracht npracht moved this from To do to Ready to commit in Testing 2.15.0 Nov 15, 2018

@Woeler Woeler merged commit 4a4bfae into mautic:staging Nov 15, 2018

2 checks passed

Scrutinizer Analysis: No new issues – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Testing 2.15.0 automation moved this from Ready to commit to Merged Nov 15, 2018

@Woeler Woeler removed the Ready To Commit label Nov 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.