Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect priority for push lead to Zoho on update #6427

Merged
merged 5 commits into from Oct 2, 2018

Conversation

Projects
4 participants
@kuzmany
Copy link
Contributor

kuzmany commented Aug 6, 2018

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #6398
BC breaks?
Deprecations?

Description:

Zoho integration use priority, but this was not applied on pushLead (form/campaign) for single contact push to integation. This PR added support for pushLead with:

  • If Mautic push contact and Zoho contact doesn't exist - pushLead create contact in Zoho with all contact fields and integrationEntity
  • If Mautic push contact and Zoho contact exist, but integrationEntity doesn't exist -> create integrationEntity and update contact on Zoho with priority fields
  • If Mautic push contact and Zoho contact/integrationEntity exist > update Zoho contct with priority fields

Steps to reproduce the bug:

  1. Set up Zoho crm sync
  2. In the mapping field, set different priority
    image
    Here I set all fields priority to Zoho except for the company contact field.
  3. Create a form with with some field. Make sure that fields on the form have different priority in the contact mapping plugin.
  4. Fill the form.
  5. Fill the form once more with same contact (same email address) but change values of other form fields.
  6. Check in Zoho that all fields have been updated. Even fields that have a zoho priority.

Steps to test this PR:

  1. Repeat all steps and see If sync works properly

@kuzmany kuzmany added this to the 2.15.0 milestone Aug 6, 2018

@kuzmany kuzmany referenced this pull request Aug 8, 2018

Closed

zoho issue with priority #6398

@johbuch

This comment has been minimized.

Copy link

johbuch commented Aug 8, 2018

just tested and it works

@npracht

npracht approved these changes Aug 8, 2018

@npracht npracht modified the milestones: 2.15.0, 2.14.2 Sep 5, 2018

@escopecz escopecz added this to Tested Once in Testing 2.14.2 Oct 2, 2018

@escopecz

This comment has been minimized.

Copy link
Member

escopecz commented Oct 2, 2018

Looks like tested twice. Thanks guys, merging...

@escopecz escopecz merged commit 3e34a3e into mautic:staging Oct 2, 2018

2 checks passed

Scrutinizer Analysis: 3 new issues, 1 updated code elements – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@escopecz escopecz moved this from Tested Once to Merged in Testing 2.14.2 Oct 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.