Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Code mode slot - placeholder #6454
Please be sure you are submitting this against the staging branch.
Code Mode block without content, or with content without input (scripts, css) are not showen in builder, then cannot select it for editation. This PR added gray block with small icon in right corner for code mode block.
You can test with https://mautibox.com/6454
Steps to reproduce the bug:
Steps to test this PR:
referenced this pull request
Aug 13, 2018
@kuzmany I was able to replicate the issue and it works well in the builder, but when I save the page/email and preview then I can see "CODEMODE" written in the content and in the HTML I can see also the buttons to delete and clone the slot. Those should not be in the result HTML.
@escopecz I cannot reproduce your issue.
Tested, I don't see the "Gray placeholder" mentioned in the PR test steps, however I do see the desired final result ( in my case a submit button) within the builder's WYSIWYG render block (left side of the screen).
So I was able to save, come back and edit again, it always worked flawlessly (just no "gray placeholder").