Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code mode slot - placeholder #6454

Merged
merged 3 commits into from Oct 7, 2018

Conversation

Projects
5 participants
@kuzmany
Copy link
Contributor

kuzmany commented Aug 13, 2018

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #6442
BC breaks?
Deprecations?

Description:

Code Mode block without content, or with content without input (scripts, css) are not showen in builder, then cannot select it for editation. This PR added gray block with small icon in right corner for code mode block.

You can test with https://mautibox.com/6454

Steps to reproduce the bug:

  1. Create an email or LP
  2. Choose a theme (not the code mode)
  3. Drag and drop the code mode bloc
  4. Insert a script inside
  5. Save the email or LP
  6. Go back on the builder and see that you won't be able to the code mode bloc anymore in the builder.

Steps to test this PR:

  1. Apply PR and run php app/console m:a:g. Mautibox is in developement mode, not require this step.
  2. Repeat all steps and see gray placeholder in CodeMode slot area

image

@johbuch

This comment has been minimized.

Copy link

johbuch commented Aug 13, 2018

tested with mautibox, it works !

@kuzmany kuzmany added the Bug label Sep 5, 2018

@kuzmany kuzmany modified the milestones: 2.15.0, 2.14.2 Sep 5, 2018

@escopecz

This comment has been minimized.

Copy link
Member

escopecz commented Sep 24, 2018

@kuzmany I was able to replicate the issue and it works well in the builder, but when I save the page/email and preview then I can see "CODEMODE" written in the content and in the HTML I can see also the buttons to delete and clone the slot. Those should not be in the result HTML.
screen shot 2018-09-24 at 21 29 17

@kuzmany

This comment has been minimized.

Copy link
Contributor Author

kuzmany commented Sep 25, 2018

@escopecz I cannot reproduce your issue.
I did again test and works for me.
I think its not related to this PR. You set something wrong and builder crash and insert some another HTML. This PR just added additional CSS to builder, on page/email preview this CSS are not used.

image

@escopecz escopecz added this to Pending Feedback in Testing 2.14.2 Oct 2, 2018

@escopecz escopecz moved this from Pending Feedback to To Do in Testing 2.14.2 Oct 2, 2018

@npracht npracht moved this from To Do to Tested Once in Testing 2.14.2 Oct 5, 2018

@YosuCadilla

This comment has been minimized.

Copy link

YosuCadilla commented Oct 7, 2018

Tested, I don't see the "Gray placeholder" mentioned in the PR test steps, however I do see the desired final result ( in my case a submit button) within the builder's WYSIWYG render block (left side of the screen).

So I was able to save, come back and edit again, it always worked flawlessly (just no "gray placeholder").

@escopecz
Copy link
Member

escopecz left a comment

Thanks @kuzmany!

@escopecz escopecz merged commit 4391a0e into mautic:staging Oct 7, 2018

2 checks passed

Scrutinizer Analysis: No new issues – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Testing 2.14.2 automation moved this from Tested Once to Merged Oct 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.