Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom text for buttons in prefs center #6455

Merged
merged 1 commit into from Sep 24, 2018

Conversation

Projects
4 participants
@kuzmany
Copy link
Contributor

kuzmany commented Aug 13, 2018

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #6429
BC breaks?
Deprecations?

Description:

This PR added support for custom text from builder for landing page prefs center.

Steps to reproduce the bug:

  1. Create a preference center
  2. Add the saveprefbutton bloc and customize the text button
    image
  3. Create an email, assign this pref center and shoot the email.
  4. Click on the unsubscribe link to land to the pref center.
  5. Check the text of the save pref button.
    image
    This is a default text.

Steps to test this PR:

  1. Apply PR and run php app/console m:a:g. Mautibox is in developement mode, not require this step.
  2. Check If your custom button text was applied
@johbuch

This comment has been minimized.

Copy link

johbuch commented Aug 13, 2018

tested on mautibox -> it works

@npracht npracht modified the milestones: 2.15.0, 2.14.2 Sep 5, 2018

@escopecz

This comment has been minimized.

Copy link
Member

escopecz commented Sep 24, 2018

Works for me. Thanks Zdeno!

@escopecz escopecz merged commit 6a8119a into mautic:staging Sep 24, 2018

2 checks passed

Scrutinizer Analysis: No new issues – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@escopecz escopecz added this to Merged in Testing 2.14.2 Oct 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.