Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix report points change log graphs #6479

Merged
merged 16 commits into from Oct 2, 2018

Conversation

Projects
6 participants
@kuzmany
Copy link
Contributor

kuzmany commented Aug 22, 2018

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #6476
BC breaks?
Deprecations?

Description:

Points log report work with graphs with sum in mysql select. If you 're using data table with graphs, and contact has more companies, then to SQL query are joined two categories tables. Then points sum number are not correct. This PR removes categories tables from graphs queries.

Steps to reproduce the bug:

  1. Create contact and assign 3 companies to this contact
  2. Create form with action with add points. Send two times these form for same contact. Then setup contact point log report
  3. Setup data table with email and company name
    image
  4. Setup graphs table: Contacts with most points
    image
  5. See graphs table display more points like your contact submitted via form

Steps to test this PR:

  1. Apply PR
  2. See correct points on graphs table

image

kuzmany added some commits Jul 4, 2018

Revert "Prevent and check columns also in filters, group by or aggreg…
…ators, not just columns"

This reverts commit 2b804b3.
Revert "Documentation update"
This reverts commit 2459154.
Merge branch 'staging' of https://github.com/mautic/mautic into fix-r…
…eports-duplicate-with-company-submissions

# Resolved conflicts:
#	app/bundles/LeadBundle/Tests/EventListener/SegmentReportSubscriberTest.php
#	app/bundles/ReportBundle/Event/ReportGeneratorEvent.php

@kuzmany kuzmany added Bug WIP labels Aug 22, 2018

kuzmany added some commits Aug 22, 2018

@npracht npracht added this to the 2.15.0 milestone Aug 23, 2018

@johbuch

This comment has been minimized.

Copy link

johbuch commented Aug 23, 2018

works for me now. Thanks

@johbuch
Copy link

johbuch left a comment

it works

@npracht npracht added this to the 2.14.2 milestone Sep 5, 2018

@npracht
Copy link
Member

npracht left a comment

Good fix

@escopecz escopecz added this to Ready to Commit in Testing 2.14.2 Oct 2, 2018

@escopecz escopecz merged commit 6116773 into mautic:staging Oct 2, 2018

2 checks passed

Scrutinizer Analysis: No new issues – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@escopecz escopecz moved this from Ready to Commit to Merged in Testing 2.14.2 Oct 2, 2018

@escopecz escopecz referenced this pull request Nov 2, 2018

Closed

Contact report with graph #6806

@mleffler

This comment has been minimized.

Copy link
Contributor

mleffler commented Dec 4, 2018

We think this code is not working properly, and seems to cause the table aliased lp to be included each time without being sure that the table has been joined, creating the exception below: '''

Uncaught PHP Exception Doctrine\DBAL\Query\QueryException: "The given alias 'lp' is not part of any FROM or JOIN clause table. The currently registered aliases are: l." at /usr/local/share/mautic/preproduction/releases/2018.12.01CR/vendor/doctrine/dbal/lib/Doctrine/DBAL/Query/QueryException.php line 37

@galvani will post a fix for community, and it should probably be in 2.15 @Woeler, your call.

cc: @npracht

@Woeler

This comment has been minimized.

Copy link
Member

Woeler commented Dec 4, 2018

Tag me when its there, preferably today.

@npracht

This comment has been minimized.

Copy link
Member

npracht commented Dec 5, 2018

I'll take time for a test as soon as PRed !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.