Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New campaign condition: Has click from channels #6488

Open
wants to merge 14 commits into
base: staging
from

Conversation

Projects
None yet
4 participants
@kuzmany
Copy link
Contributor

kuzmany commented Aug 26, 2018

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #6466
BC breaks?
Deprecations?

Description:

Based on discussion #6466 (comment)

We can work with all clicked/non clicked contacts by new Campaign condition: Has click from channels

image

Steps to test this PR:

  1. Create clicks from channels (notification, email, sms..)
  2. Create campaign with new condition: Has click from channels + test include/exclude URLs with * (see tooltip for more info)
  3. Test If return true/false based on your contact state

Test by Mautibox: https://mautibox.com/6488/s/login

@kuzmany kuzmany added this to the 2.15.0 milestone Aug 26, 2018

kuzmany added some commits Aug 26, 2018

@kuzmany kuzmany changed the title New campaign condition: Has clicks from channel New campaign condition: Has click from channels Aug 27, 2018

@kuzmany kuzmany added Ready To Test and removed WIP labels Aug 27, 2018

kuzmany added some commits Aug 27, 2018

@johbuch

This comment has been minimized.

Copy link

johbuch commented Aug 28, 2018

tested it --> works !
thanks

@johbuch
Copy link

johbuch left a comment

works for me

@kuzmany kuzmany added the WIP label Sep 6, 2018

@kuzmany kuzmany added Ready To Test and removed WIP labels Sep 21, 2018

@kuzmany

This comment has been minimized.

Copy link
Contributor Author

kuzmany commented Sep 21, 2018

@johbuch can you test again with include/exclude Urls function

image

@npracht npracht added this to Pending feedback in Testing 2.15.0 Oct 16, 2018

@npracht npracht removed the Ready To Test label Oct 16, 2018

@npracht npracht self-assigned this Nov 8, 2018

@npracht npracht moved this from Pending feedback to To do in Testing 2.15.0 Nov 19, 2018

@kuzmany

This comment has been minimized.

Copy link
Contributor Author

kuzmany commented Dec 3, 2018

@johbuch can you retest it? 🥇

@npracht npracht modified the milestones: 2.15.0, 2.15.1, 2.16.0 Dec 4, 2018

@Woeler Woeler removed this from To do in Testing 2.15.0 Dec 5, 2018

@YosuCadilla

This comment has been minimized.

Copy link

YosuCadilla commented Dec 5, 2018

Tested with existing campaign, when I clicked on the link I got -10 points, when I opened the email but did NOT click on the link, I also got -10 points so I would think it's rather not counting clicks.

@kuzmany

This comment has been minimized.

Copy link
Contributor Author

kuzmany commented Dec 5, 2018

@YosuCadilla can you share that campaign?

@YosuCadilla

This comment has been minimized.

Copy link

YosuCadilla commented Dec 6, 2018

It's the campaign that came "pre-installed" on the instance.

@heathdutton heathdutton added this to Code Review (2 required) in Mautic 2 Dec 6, 2018

@heathdutton heathdutton removed this from Code Review (2 required) in Mautic 2 Dec 6, 2018

@kuzmany

This comment has been minimized.

Copy link
Contributor Author

kuzmany commented Dec 8, 2018

@YosuCadilla you can also test If you click on link. You can take link from mail log https://mautibox.com/mail/ and open it in inkognito You should enable Identify by tracking url in Configuration > Tracking
The campaign should go to true.

@YosuCadilla

This comment has been minimized.

Copy link

YosuCadilla commented Dec 9, 2018

I finally got my 33 points added, test passed!
Thank you for the additional instructions @kuzmany

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.