Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pagination for integration fields #6504

Closed
wants to merge 1 commit into
base: staging
from

Conversation

Projects
None yet
3 participants
@kuzmany
Copy link
Contributor

kuzmany commented Aug 29, 2018

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

Noticed pagination doesn't work in integration. This PR fixed it

Steps to reproduce the bug:

  1. Install NetSuite plugin via command line by composer require kuzmany/mautic-netsuite-bundle from Mautic root
  2. Go to Mautic - Plugins and click to the button Install/Upgrade plugins
  3. Setup custom credits and enable contact object
  4. See contact matching tab and try paginate
  5. Should return error

Steps to test this PR:

  1. Repeat all steps and see If pagination work

@kuzmany kuzmany added Bug WIP labels Aug 29, 2018

@kuzmany kuzmany added this to the 2.15.0 milestone Aug 29, 2018

@kuzmany kuzmany added Ready To Test and removed WIP labels Aug 29, 2018

@npracht npracht modified the milestones: 2.15.0, 2.14.2 Sep 5, 2018

@npracht

npracht approved these changes Oct 2, 2018

Copy link
Member

npracht left a comment

👍

@escopecz escopecz added this to Tested Once in Testing 2.14.2 Oct 2, 2018

@escopecz

This comment has been minimized.

Copy link
Member

escopecz commented Oct 2, 2018

@kuzmany isn't it a problem of the 1 specific integration? None other CRM integrations does not have this problem. I'd suggest to fix this in the integration.

@escopecz escopecz moved this from Tested Once to Pending Feedback in Testing 2.14.2 Oct 2, 2018

@kuzmany

This comment has been minimized.

Copy link
Contributor Author

kuzmany commented Oct 3, 2018

@escopecz I will check it I thought more integration has same issue.

@kuzmany

This comment has been minimized.

Copy link
Contributor Author

kuzmany commented Oct 4, 2018

@escopecz You're right. Close it.

@kuzmany kuzmany closed this Oct 4, 2018

@kuzmany kuzmany removed this from Pending Feedback in Testing 2.14.2 Oct 4, 2018

@kuzmany kuzmany removed this from the 2.14.2 milestone Oct 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.