New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change UTF8 to utf8mb4 for new installation #6554

Closed
wants to merge 6 commits into
base: staging
from

Conversation

Projects
None yet
3 participants
@kuzmany
Copy link
Contributor

kuzmany commented Sep 11, 2018

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

Based on this discussion #6490 and this article https://mathiasbynens.be/notes/mysql-utf8mb4
This PR add as default charset utf8mb4 which allow use all unicode symbols (like emoji)

Conclusion from article

Never use utf8 in MySQL — always use utf8mb4 instead. Updating your databases and code might take some time, but it’s definitely worth the effort. Why would you arbitrarily limit the set of symbols that can be used in your database? Why would you lose data every time a user enters an astral symbol as part of a comment or message or whatever it is you store in your database? There’s no reason not to strive for full Unicode support everywhere. Do the right thing, and use utf8mb4. 🍻

Steps to test this PR:

  1. Create new installation
  2. Go to emails, create email with 🥐 emoji in subject
  3. Should works properly.

List backwards compatibility breaks:

Hard to say. We have to setup VARCHAR to 191 lenght. More in FriendsOfSymfony/FOSUserBundle#1919 (comment)

@kuzmany kuzmany added this to the 2.15.0 milestone Sep 11, 2018

kuzmany added some commits Sep 12, 2018

@kuzmany

This comment has been minimized.

Copy link
Contributor

kuzmany commented Sep 17, 2018

I do research and for example Wordpress done changed for encoding utf8 to utf8mb4 in April 23, 2015

https://make.wordpress.org/core/2015/04/02/the-utf8mb4-upgrade/

That we should make this update 3 years later, What do you think? :) @alanhartless @dbhurley @escopecz @npracht

We should

  • forced new installation to utf8mb4 (without config)
  • upgrade current mautic to utf8mb4 if it possible

Becouse it's huge core change I need feedback from core team before we start working on it.

@alanhartless

This comment has been minimized.

Copy link
Contributor

alanhartless commented Sep 17, 2018

@kuzmany

This comment has been minimized.

Copy link
Contributor

kuzmany commented Sep 21, 2018

Close at the moment.
Related discussion on slack: https://mautic.slack.com/archives/C02HU8AUF/p1537194307000100

@kuzmany kuzmany closed this Sep 21, 2018

@escopecz escopecz removed this from the 2.15.0 milestone Sep 24, 2018

@kuzmany kuzmany referenced this pull request Sep 29, 2018

Merged

Fix social monitoring job #5761

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment