Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Send email by API return not found even If email entity exists #6581

Merged
merged 1 commit into from Oct 9, 2018

Conversation

Projects
3 participants
@kuzmany
Copy link
Contributor

kuzmany commented Sep 14, 2018

Please be sure you are submitting this against the staging branch.

Q A
Bug fix? Yes
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

Notice bad condition statement during the send email aciton by API.
Code check should be enought.

Test with Mautibox: https://mautibox.com/6581

Steps to reproduce the bug:

  1. Jus try send published email by API
$apiEmails = $api->newApi('emails', $auth, $apiUrl);
$r = $apiEmails->sendToContact($emailId, $contactId);
print_r($r);
  1. Response should return not found

Steps to test this PR:

  1. Repeat all steps
  2. See published email is sent correctly

@kuzmany kuzmany added this to the 2.14.2 milestone Sep 14, 2018

@kuzmany kuzmany changed the title Fix: Send email by API return not found even If email exists Fix: Send email by API return not found even If email entity exists Sep 14, 2018

@escopecz escopecz added this to To Do in Testing 2.14.2 Oct 2, 2018

@escopecz
Copy link
Member

escopecz left a comment

The code is correct. Thanks Zdeno! 👍

@escopecz escopecz moved this from To Do to Tested Once in Testing 2.14.2 Oct 5, 2018

@Woeler

Woeler approved these changes Oct 9, 2018

Copy link
Member

Woeler left a comment

Tested with https://mautibox.com/6581 and working. Emails that exist return true, emails that don't exist return not found.

@escopecz escopecz merged commit f537bee into mautic:staging Oct 9, 2018

2 checks passed

Scrutinizer Analysis: No new issues – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Testing 2.14.2 automation moved this from Tested Once to Merged Oct 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.