Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alias for company ID to avoid Ids mismatch #6585

Merged
merged 2 commits into from Oct 7, 2018

Conversation

Projects
5 participants
@kuzmany
Copy link
Contributor

kuzmany commented Sep 14, 2018

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #6517
BC breaks?
Deprecations?

Description:

Based on this issue report: #6517
If you choose in report Contact ID and Company ID, both has alias ID in SQL query.

SELECT l.email AS email, l.id AS id, comp.id AS id FROM leads

This PR added alias for comp.id

Test with Mautibox: https://mautibox.com/6585

Steps to reproduce the bug:

  1. Create contact report with Contact ID, Company ID and Contact Email
  2. See table, with same Ids

image

Steps to test this PR:

  1. Repeat all steps
  2. See correct IDs
  3. Query should be
    SELECT l.email AS email, l.id AS id, comp.id AS comp_id FROM leads
@johbuch

This comment has been minimized.

Copy link

johbuch commented Sep 14, 2018

works with mautibox

@npracht

npracht approved these changes Oct 2, 2018

Copy link
Member

npracht left a comment

👍

@escopecz escopecz added this to Tested Once in Testing 2.14.2 Oct 2, 2018

@YosuCadilla

This comment has been minimized.

Copy link

YosuCadilla commented Oct 7, 2018

Test success!
untitled

@escopecz escopecz merged commit 6465a04 into mautic:staging Oct 7, 2018

2 checks passed

Scrutinizer Analysis: No new issues – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Testing 2.14.2 automation moved this from Tested Once to Merged Oct 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.