Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change contact field Company to Primary company #6615

Merged
merged 1 commit into from Oct 8, 2018

Conversation

Projects
3 participants
@kuzmany
Copy link
Contributor

kuzmany commented Sep 20, 2018

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #6590
BC breaks?
Deprecations?

Description:

Based on this issue: #6590
From my view there is misunderstanding with company name. At the moment we have two company name attribute

  • first as contact field (formally primary company)
  • second as company name of company entity

That make confusing for example with reports If I choose Company or Company Name (screenshots here #6590 (comment))

My suggestion rename Company as contact field to Primary company.

Steps to reproduce the bug:

  1. Go to reports and create two different reports with Company and Company Name
  2. You will see different results. Thats weird, nobody understand it

Steps to test this PR:

  1. Go to reports and create two different reports with Primary and Company Name
  2. I think now It's clear
@npracht

npracht approved these changes Oct 2, 2018

Copy link
Member

npracht left a comment

Ok that works for me but i'd love to have @escopecz opinion :)

@escopecz escopecz added this to Tested Once in Testing 2.14.2 Oct 2, 2018

@escopecz
Copy link
Member

escopecz left a comment

👍

@escopecz escopecz merged commit abc194e into mautic:staging Oct 8, 2018

2 checks passed

Scrutinizer Analysis: No new issues – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Testing 2.14.2 automation moved this from Tested Once to Merged Oct 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.