Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default value rewrite on import #6616

Merged
merged 1 commit into from Sep 24, 2018

Conversation

Projects
5 participants
@kuzmany
Copy link
Contributor

kuzmany commented Sep 20, 2018

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #6607
BC breaks?
Deprecations?

Description:

On import default value was rewrite with for both Contact/Company.
This PR fixed it.

Steps to reproduce the bug:

  1. Create contact with custom field with default value
  2. Edit this contact and change value of the custom fiel
  3. Create import file without custom field in import
  4. See custom field was change to default value after import

Steps to test this PR:

  1. Repeat all steps
  2. See If custom field wasn't rewrite
@johbuch
Copy link

johbuch left a comment

it works

@escopecz
Copy link
Member

escopecz left a comment

Code makes sense 👍

@escopecz escopecz merged commit 60afbb2 into mautic:staging Sep 24, 2018

2 checks passed

Scrutinizer Analysis: No new issues – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@escopecz escopecz added this to Merged in Testing 2.14.2 Oct 2, 2018

@XRaccourci

This comment has been minimized.

Copy link
Contributor

XRaccourci commented Oct 13, 2018

The problem is not completely solved.
Importing contacts with a file that does not contain the multiple-value list field, does not rewrite the value. This problem is fixed.
But if the import of contacts with a file that contains the multiple-value list field empty, the value of the contact is not updated by default value set for this field.
If the field is filled mautic should update the value of contact.
What do you think ?

@escopecz

This comment has been minimized.

Copy link
Member

escopecz commented Oct 13, 2018

@XRaccourci can you create a new issue for that? Your comment on a merged PR may get overlooked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.