Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix contact name campaign fail log on send marketing email #6637

Merged
merged 2 commits into from Nov 14, 2018

Conversation

Projects
6 participants
@kuzmany
Copy link
Contributor

kuzmany commented Sep 24, 2018

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

If you send multiple emails by campaigns, and use marketing message. The fail log in campaign return wrong contact name.

Steps to reproduce the bug:

  1. Create campaign with two send email action as marketing message
  2. Add two contacts
  3. Send it and see fail notification for both contact in notification area. Both has same name as contacnt

image

Steps to test this PR:

  1. Repeat all steps and see notifciation return name for each contact as we excepted

@kuzmany kuzmany added this to the 2.14.2 milestone Sep 24, 2018

@escopecz escopecz added this to To Do in Testing 2.14.2 Oct 2, 2018

@escopecz escopecz modified the milestones: 2.14.2, 2.15.0 Oct 16, 2018

@npracht npracht added this to To do in Testing 2.15.0 Oct 16, 2018

@Dcoutelle
Copy link
Contributor

Dcoutelle left a comment

Work as described

@Woeler Woeler moved this from To do to Tested once in Testing 2.15.0 Nov 7, 2018

@npracht npracht self-assigned this Nov 7, 2018

@dbhurley dbhurley modified the milestone: 2.15.0 Nov 9, 2018

@Woeler

Woeler approved these changes Nov 14, 2018

Copy link
Member

Woeler left a comment

Working

@Woeler Woeler merged commit 9b0c3e8 into mautic:staging Nov 14, 2018

2 checks passed

Scrutinizer Analysis: No new issues – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Testing 2.15.0 automation moved this from Tested once to Merged Nov 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.