Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add placeholder to phone field type #6685

Merged
merged 1 commit into from Oct 9, 2018

Conversation

Projects
3 participants
@kuzmany
Copy link
Contributor

kuzmany commented Oct 5, 2018

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

Just added forgotten placeholder to phone field type.

image

Steps to reproduce the bug:

  1. Add to form phone field type
  2. Placeholder missing

Steps to test this PR:

  1. Add to form phone field type
  2. Placeholder is back

@kuzmany kuzmany added this to the 2.14.2 milestone Oct 5, 2018

@kuzmany kuzmany added this to To Do in Testing 2.14.2 Oct 8, 2018

@escopecz
Copy link
Member

escopecz left a comment

Works for me 👍

@escopecz escopecz moved this from To Do to Tested Once in Testing 2.14.2 Oct 8, 2018

@Maxell92
Copy link
Contributor

Maxell92 left a comment

Works for me

@escopecz escopecz merged commit b2c685d into mautic:staging Oct 9, 2018

2 checks passed

Scrutinizer Analysis: No new issues – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Testing 2.14.2 automation moved this from Tested Once to Merged Oct 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.