Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix focus campaign action - add local session to tracking helper #6723

Open
wants to merge 4 commits into
base: staging
from

Conversation

Projects
None yet
2 participants
@kuzmany
Copy link
Contributor

kuzmany commented Oct 12, 2018

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

This PR prevent waiting for update session If campaign action is executed after page visits.
Tracking helper in first step try check local cache, then check in session.

Steps to reproduce the bug:

  1. Create campaign with Page visits decision and after Focus action

image

  1. The action is not executed every time. It's little tricky test it, but If I run this campaign on production I have few Focus fired, even all action are executed. Just check focus stats and it's not same (focus stats are lower) like campaign action triggered stats.

Steps to test this PR:

  1. Repeat same camapign
  2. Focus should fire every time

@kuzmany kuzmany added this to the 2.15.0 milestone Oct 12, 2018

@kuzmany kuzmany changed the title Add local session to tracking helper Fix focus campaign action - add local session to tracking helper Oct 12, 2018

@npracht npracht added this to To do in Testing 2.15.0 Oct 16, 2018

@npracht npracht modified the milestones: 2.15.0, 2.16.0 Dec 4, 2018

@Woeler Woeler removed this from To do in Testing 2.15.0 Dec 5, 2018

@heathdutton heathdutton added this to Code Review (2 required) in Mautic 2 Dec 6, 2018

@heathdutton heathdutton removed this from Code Review (2 required) in Mautic 2 Dec 6, 2018

@npracht npracht added this to Ready to Test (first time) in Mautic 2 Jan 3, 2019

@npracht npracht removed this from Ready to Test (first time) in Mautic 2 Jan 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.