Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix z-index for gated video #6750

Merged
merged 1 commit into from Nov 7, 2018

Conversation

Projects
3 participants
@kuzmany
Copy link
Contributor

kuzmany commented Oct 16, 2018

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #6745
BC breaks?
Deprecations?

Description:

Gated video allow continue video without send from.
This PR fixed it by increase z-index of layer

Steps to reproduce the bug:

  1. Add an MP4 video as an asset (must end with mp4)
  2. Create a landing page, add a gated video bloc and add the URL of the mp4 you just upload
    image
  3. Save and close
  4. Open the landing page, start the video and wait for the form to display
  5. See the play video
    image
  6. Do not submit the form, just click on the play button and see that the video continue to play

Steps to test this PR:

  1. Repeat all steps and see If play button is not clickable

@kuzmany kuzmany added this to the 2.15.0 milestone Oct 16, 2018

@kuzmany kuzmany added WIP and removed WIP labels Oct 16, 2018

@npracht npracht added the Code Review label Oct 17, 2018

@npracht npracht added this to To do in Testing 2.15.0 Oct 17, 2018

@@ -1001,7 +1001,7 @@ div.mejs-speed-button {
.mejs-poster {
text-align: center;
background: rgba(0,0,0,0.75);
z-index: 1000;
z-index: 100000000;

This comment has been minimized.

@npracht

npracht Oct 19, 2018

Member

I don't know if this is a good practice to go so high in the number but it works.

This comment has been minimized.

@kuzmany

kuzmany Oct 19, 2018

Author Contributor

Its priority for layers. Now form gated layer has higher priority

@npracht npracht moved this from To do to Tested once in Testing 2.15.0 Oct 22, 2018

@Woeler

Woeler approved these changes Nov 7, 2018

Copy link
Member

Woeler left a comment

Working for me

@Woeler Woeler moved this from Tested once to Ready to commit in Testing 2.15.0 Nov 7, 2018

@Woeler Woeler merged commit bb58f35 into mautic:staging Nov 7, 2018

2 checks passed

Scrutinizer Analysis: No new issues – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Testing 2.15.0 automation moved this from Ready to commit to Merged Nov 7, 2018

@Woeler Woeler removed the Ready To Commit label Nov 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.