Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force set SITE URL as host to route loader #6752

Closed
wants to merge 2 commits into
base: staging
from

Conversation

Projects
None yet
3 participants
@kuzmany
Copy link
Contributor

kuzmany commented Oct 17, 2018

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

I think, this one line change also resolve this pull request #6206
If you change Mautic URL, but stay on previus URL of Mautic, then a embeded form script link use old Mautic URL. This PR set host forced by SITE URL from Configuration.

image

Steps to reproduce the bug:

  1. Setup two different URL to same Mautic url
  2. Go to detail page of landing page
  3. Check Public Preview URL
  4. Then go to Configuration and change Site URL of Mautic
  5. Go to detail page of landing page
  6. Check Public Preview URL.
  7. Site URL configuration change don't apply to URL of public preview, but we expect new SITE URL

Steps to test this PR:

  1. Repeat all steps
  2. Public Preview URL. of landing page should have new SITE URL even If you navigate via old URL of Mautic

@kuzmany kuzmany added this to the 2.15.0 milestone Oct 17, 2018

@kuzmany kuzmany added this to To do in Testing 2.15.0 Oct 17, 2018

@kuzmany kuzmany changed the title Force set site_url as host to route loader Force set SITE URL as host to route loader Oct 17, 2018

@jbransen

This comment has been minimized.

Copy link
Contributor

jbransen commented Oct 19, 2018

This does not work correctly. It sets the hostname, but if you run Mautic in a subdirectory in one of the hostnames things go wrong.

I.e. I can access my Mautic installation via 2 different url's:

Now when I set the site_url to the second one but access Mautic via the first one, I get a url like https://hostB/mautic/email/preview/1

@kuzmany

This comment has been minimized.

Copy link
Contributor Author

kuzmany commented Oct 19, 2018

@jbransen Yes.
But If you have setup Mautic on another domain like you use in browser, you cannot expect the correct way of working.
Maybe solution should be after change configuration, force redirect to correct domain.

@npracht npracht modified the milestones: 2.15.0, 2.16.0 Dec 4, 2018

@Woeler Woeler removed this from To do in Testing 2.15.0 Dec 5, 2018

@heathdutton heathdutton added this to Code Review (2 required) in Mautic 2 Dec 6, 2018

@heathdutton heathdutton removed this from Code Review (2 required) in Mautic 2 Dec 6, 2018

@npracht npracht added this to Ready to Test (first time) in Mautic 2 Jan 3, 2019

@npracht npracht removed this from Ready to Test (first time) in Mautic 2 Jan 3, 2019

@kuzmany

This comment has been minimized.

Copy link
Contributor Author

kuzmany commented Feb 13, 2019

Close favor to #7193 (better solution)

@kuzmany kuzmany closed this Feb 13, 2019

@kuzmany kuzmany removed this from the 2.16.0 milestone Feb 13, 2019

@kuzmany kuzmany removed the Ready To Test label Feb 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.