Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DateTimeInterface instance check to TwitterCommandHelper #6758

Merged
merged 1 commit into from Oct 23, 2018

Conversation

Projects
None yet
2 participants
@kuzmany
Copy link
Contributor

kuzmany commented Oct 18, 2018

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

Based on this discussion #5761 (review)

Steps to test this PR:

Code review should be enough

@kuzmany kuzmany added this to the 2.14.2 milestone Oct 18, 2018

@kuzmany kuzmany requested a review from escopecz Oct 18, 2018

@escopecz
Copy link
Member

escopecz left a comment

Perfect! Thanks! 👍

@escopecz escopecz merged commit c4349a6 into mautic:staging Oct 23, 2018

2 checks passed

Scrutinizer Analysis: No new issues – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.