Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix frequency rule #6760

Merged
merged 2 commits into from Nov 8, 2018

Conversation

Projects
None yet
5 participants
@kuzmany
Copy link
Contributor

kuzmany commented Oct 18, 2018

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #6729
BC breaks?
Deprecations?

Description:

Based on this issue #6729 I notice bad condition If frequency rules should applied.

Steps to reproduce the bug:

  1. Go to configurations, Emails and set Default Frequency Rule to 1 each week
    image
  2. Create two campaign width send email action
  3. Run both campaign
  4. See contact profile page, both email send, even we set frequency rule

Steps to test this PR:

  1. Repeat all steps and see If second email is pending

@kuzmany kuzmany added this to the 2.15.0 milestone Oct 18, 2018

@kuzmany kuzmany added this to To do in Testing 2.15.0 Oct 18, 2018

@johbuch
Copy link

johbuch left a comment

Tested and works properly ! thanks

@npracht npracht moved this from To do to Tested once in Testing 2.15.0 Oct 22, 2018

@Woeler

Woeler approved these changes Nov 8, 2018

Copy link
Member

Woeler left a comment

Good to go

@Woeler Woeler moved this from Tested once to Ready to commit in Testing 2.15.0 Nov 8, 2018

@Woeler Woeler merged commit a7bb9e5 into mautic:staging Nov 8, 2018

2 checks passed

Scrutinizer Analysis: No new issues – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Testing 2.15.0 automation moved this from Ready to commit to Merged Nov 8, 2018

@Woeler Woeler removed the Ready To Commit label Nov 8, 2018

@alanhartless

This comment has been minimized.

Copy link
Contributor

alanhartless commented Nov 8, 2018

@kuzmany @Woeler this is wrong :-( Frequency rules should only apply to marketing communication but this PR seems to have changed it to apply only to transactional emails. It's going to apply frequency rules to form submission confirmations and the like instead broadcasts/segment sends.

@Woeler Woeler referenced this pull request Nov 8, 2018

Merged

Revert "Fix frequency rule" #6849

@Woeler Woeler removed this from Merged in Testing 2.15.0 Nov 10, 2018

@alanhartless

This comment has been minimized.

Copy link
Contributor

alanhartless commented Nov 16, 2018

@kuzmany just a ping so we don't lose track of this since it was reverted via #6849.

@kuzmany kuzmany added the WIP label Nov 16, 2018

@kuzmany

This comment has been minimized.

Copy link
Contributor Author

kuzmany commented Nov 16, 2018

@alanhartless got it, will work on in it, next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.