Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contact campaign action - new options to update fields #6805

Open
wants to merge 12 commits into
base: staging
from

Conversation

6 participants
@kuzmany
Copy link
Contributor

kuzmany commented Nov 1, 2018

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #6553
BC breaks?
Deprecations?

Description:

Follow up to #6587

This PR extend Update contact campaign action with 3 actions:

  • update field
  • empty field
  • add values (for multiple select field)
  • remove values (for multiple select field)

image

Steps to test this PR:

  1. Create update action and test update/empty field
  2. Test also add/remove values from multiple select field
  3. Also test migrations with from old to new update campaign action
@johbuch

This comment has been minimized.

Copy link

johbuch commented Nov 2, 2018

@kuzmany I just tested on mautibox but it did not work for me
Here what I set
image

After campaign triggered
image

nothings changed
image

@kuzmany

This comment has been minimized.

Copy link
Contributor Author

kuzmany commented Nov 2, 2018

@johbuch not ready to test, marked as work in progress ;)

kuzmany added some commits Nov 2, 2018

@kuzmany kuzmany added Ready To Test and removed WIP labels Nov 2, 2018

@kuzmany

This comment has been minimized.

Copy link
Contributor Author

kuzmany commented Nov 2, 2018

@johbuch now it's ready to test ;)

@johbuch

johbuch approved these changes Nov 5, 2018

Copy link

johbuch left a comment

@kuzmany sorry about the 1st test (I thought it was ok), so i just tested again and it works

@npracht npracht added this to Tested once in Testing 2.15.0 Nov 5, 2018

@dbhurley dbhurley modified the milestone: 2.15.0 Nov 9, 2018

@escopecz escopecz added the Backlog label Nov 16, 2018

@escopecz

This comment has been minimized.

Copy link
Member

escopecz commented Nov 16, 2018

@kuzmany there are some conflicts

@kuzmany kuzmany added Has Conflicts and removed Backlog labels Nov 16, 2018

@escopecz escopecz moved this from Tested once to Pending feedback in Testing 2.15.0 Nov 16, 2018

@kuzmany kuzmany added the WIP label Nov 16, 2018

@kuzmany

This comment has been minimized.

Copy link
Contributor Author

kuzmany commented Nov 16, 2018

guys wait, need re-test and improve migrations

kuzmany added some commits Nov 16, 2018

@kuzmany kuzmany removed the WIP label Nov 16, 2018

@kuzmany

This comment has been minimized.

Copy link
Contributor Author

kuzmany commented Nov 16, 2018

Now fixed. Please re-test and focus also on migrations.

@npracht

This comment has been minimized.

Copy link
Member

npracht commented Nov 19, 2018

@kuzmany I have an improvement about this. at the moment with what you developed, we can choose a field and update it or empty it or remove values.
image
With select multiple fields, it could be nice to have another option which would be to add values. Because if you already have some value, if you select update it will update with the values and remove the one that contacts have. So if we could just add a new value

kuzmany added some commits Nov 19, 2018

@kuzmany

This comment has been minimized.

Copy link
Contributor Author

kuzmany commented Nov 19, 2018

@npracht added Add values, please test ;)

@npracht npracht moved this from Pending feedback to Tested once in Testing 2.15.0 Nov 19, 2018

@johbuch
Copy link

johbuch left a comment

just tested the new feature add values on mautibox, works great !
thanks

@Woeler Woeler moved this from Tested once to Ready to commit in Testing 2.15.0 Nov 21, 2018

@Woeler Woeler moved this from Ready to commit to Tested once in Testing 2.15.0 Nov 21, 2018

@Woeler Woeler modified the milestones: 2.15.0, 2.16.0 Dec 5, 2018

@Woeler Woeler removed this from Tested once in Testing 2.15.0 Dec 5, 2018

@heathdutton heathdutton added this to Code Review (2 required) in Mautic 2 Dec 6, 2018

@heathdutton heathdutton removed this from Code Review (2 required) in Mautic 2 Dec 6, 2018

@npracht npracht added this to Ready to Test (confirmation) in Mautic 2 Jan 3, 2019

@npracht npracht moved this from Ready to Test (confirmation) to Code Review (2 required) in Mautic 2 Jan 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.