Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Lost campaign segments after clone campaign #6818

Merged
merged 2 commits into from Nov 25, 2018

Conversation

Projects
5 participants
@kuzmany
Copy link
Contributor

kuzmany commented Nov 5, 2018

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #5682
BC breaks?
Deprecations?

Description:

This issue is reported #5682
After clone campaign, if you launch builder and edit segments source, the campaign during save entity, lost segment source.

Steps to reproduce the bug:

  1. Clone a campaign that starts with a segment
  2. Go on the builder
  3. Click on the segment, do not change it (keep the same segment) but just click on update
  4. Close the builder, save and close the campaign.
  5. Go back on the campaign and go back on the builder,
  6. You will see that there are no segments anymore

Steps to test this PR:

.1. Repeat all steps and see If cloning works propely

@kuzmany kuzmany added this to the 2.15.0 milestone Nov 5, 2018

@kuzmany kuzmany added this to To do in Testing 2.15.0 Nov 5, 2018

@escopecz escopecz self-assigned this Nov 7, 2018

@johbuch
Copy link

johbuch left a comment

just tested on mautibox it works

@escopecz

This comment has been minimized.

Copy link
Member

escopecz commented Nov 16, 2018

@kuzmany could you rebase to latest staging? I think it should fix Travis.

@escopecz escopecz removed the Code Review label Nov 16, 2018

@escopecz escopecz moved this from To do to Tested once in Testing 2.15.0 Nov 16, 2018

@escopecz
Copy link
Member

escopecz left a comment

Works as described 👍 Thanks Zdeno!

@escopecz escopecz moved this from Tested once to Ready to commit in Testing 2.15.0 Nov 25, 2018

@escopecz escopecz removed their assignment Nov 25, 2018

@Woeler Woeler removed the Ready To Commit label Nov 25, 2018

@Woeler Woeler merged commit 61f3737 into mautic:staging Nov 25, 2018

2 checks passed

Scrutinizer Analysis: 3 new issues – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Testing 2.15.0 automation moved this from Ready to commit to Merged Nov 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.