Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new inject custom hook to email settings #6840

Merged
merged 3 commits into from Dec 4, 2018

Conversation

Projects
3 participants
@kuzmany
Copy link
Contributor

kuzmany commented Nov 8, 2018

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

Based on our discussion #5288 (comment) I add new content hook to email settings. We would like extend email settings by plugin in our new project.

Steps to test this PR:

  1. Just code review or try create new email in mautibox

@kuzmany kuzmany added this to the 2.15.0 milestone Nov 8, 2018

@kuzmany kuzmany added this to To do in Testing 2.15.0 Nov 8, 2018

@kuzmany kuzmany added the L1 label Nov 8, 2018

@kuzmany

This comment has been minimized.

Copy link
Contributor Author

kuzmany commented Dec 4, 2018

@Woeler I think this PR need just code review, it's not big deal
@escopecz do you have one second to look and approve it?

@escopecz
Copy link
Member

escopecz left a comment

Code looks fine. Quick-tested just to be sure. No problem found.

@escopecz escopecz moved this from To do to Tested once in Testing 2.15.0 Dec 4, 2018

@Woeler

Woeler approved these changes Dec 4, 2018

Copy link
Member

Woeler left a comment

Found no problems.

@Woeler Woeler moved this from Tested once to Ready to commit in Testing 2.15.0 Dec 4, 2018

@Woeler Woeler merged commit d113b2c into mautic:staging Dec 4, 2018

2 checks passed

Scrutinizer Analysis: 4 new issues – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Testing 2.15.0 automation moved this from Ready to commit to Merged Dec 4, 2018

@Woeler Woeler removed the Ready To Commit label Dec 4, 2018

@kuzmany

This comment has been minimized.

Copy link
Contributor Author

kuzmany commented Dec 4, 2018

We've already used it with one plugin on production server ;) Thats cool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.