Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send a webhook event #6873

Open
wants to merge 10 commits into
base: staging
from

Conversation

2 participants
@kuzmany
Copy link
Contributor

kuzmany commented Nov 13, 2018

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

This PR added new dispatcher to send a webhook campaign action what allow for devs work with wbhook response.

Steps to test this PR:

  1. Install plugin https://github.com/kuzmany/mautic-extendee-webhook-response-bundle
  2. Use decision Response from webhook after Send a webhook

@kuzmany kuzmany added this to the 2.15.1 milestone Nov 13, 2018

@kuzmany kuzmany changed the title Send a webhook event Send a webhook event and new webhook reponse decision Nov 13, 2018

kuzmany added some commits Nov 13, 2018

@kuzmany kuzmany changed the title Send a webhook event and new webhook reponse decision Send a webhook event Nov 13, 2018

kuzmany added some commits Nov 14, 2018

@heathdutton heathdutton added this to Code Review (2 required) in Mautic 2 Dec 6, 2018

@npracht npracht moved this from Code Review (2 required) to Ready to Test (first time) in Mautic 2 Jan 3, 2019

@alanhartless alanhartless added this to Needs Testing in 2.15.1 Jan 14, 2019

Mautic 2 automation moved this from Ready to Test (first time) to Changes Requested / Review Jan 30, 2019

*
* @var string
*/
const ON_SEND_WEBHOOK = 'mautic.webhook.campaign_on_send_webhook';

This comment has been minimized.

@alanhartless

alanhartless Jan 30, 2019

Contributor

Let's rename this event to match it's action as it's not dispatched when we "send" the webhook but when we are handling the response. const ON_WEBHOOK_RESPONSE = 'mautic.webhook.on_response';

@alanhartless

This comment has been minimized.

Copy link
Contributor

alanhartless commented Jan 30, 2019

@kuzmany can you also handle the conflict? Thanks!

@alanhartless alanhartless moved this from Needs Testing to Discussion in 2.15.1 Jan 30, 2019

changes made

@alanhartless alanhartless modified the milestones: 2.15.1, 2.16.0 Mar 11, 2019

@alanhartless alanhartless removed this from Discussion in 2.15.1 Mar 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.