Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix frequency rules #6896
Please be sure you are submitting this against the staging branch.
Based on this issue #6729 I notice bad condition If frequency rules should applied.
Steps to reproduce the bug:
Steps to test this PR:
referenced this pull request
Nov 16, 2018
Nov 30, 2018
This will apply frequency rules to all outgoing email including transactional which is not correct. Emails like form submissions emails "thank you for submitting our form!" should not be moderated by frequency rules.
This is not the bug and the PR should be converted. If you want the campaign to be moderated by frequency rules, you need to set the send email action to be a "marketing" email.
We have to be really careful with making "global" fixes for "localized" bugs.
Moreover there is a misunderstood here. Transactional email are not email that you can unsubscribe from (autoresponder, purchase, account creation). Marketing email yes.
Because it is not managed like that, i thought the the mention of
We'll have to take car of the feature definition and guideline in M3 around here and use the proper "words". I'll add it to the list of points to care about.
@npracht agreed but we should probably put that in it's own issue if it's not there already as that is a system wide behavior versus campaign behavior.
@kuzmany Sorry, I meant in the code I referenced.