Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not contains support for form value condition expression with notLike #6905

Open
wants to merge 2 commits into
base: staging
from

Conversation

3 participants
@kuzmany
Copy link
Contributor

kuzmany commented Nov 20, 2018

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

Added same logic to form field value condition like segments fitler do for like/notLike https://github.com/kuzmany/mautic/blob/f5fd2cf553eec037f7b6211c193f8675d2331b40/app/bundles/LeadBundle/Segment/Decorator/BaseDecorator.php#L131-L131

That means, If search value doesn't contain % symbol, we add it %value%

Steps to test this PR:

  1. Send two times form results with different values
    For example If your multiselect choice has first, second, third value, then
  • first result: second, third
    .-second result: first, third
  1. Create form field value condition with not like for multi select for notLike first
    3 You should be a true in campaign

@kuzmany kuzmany added this to the 2.15.1 milestone Nov 20, 2018

@kuzmany kuzmany changed the title Not contains support for form value condition expression notLike Not contains support for form value condition expression with notLike Nov 20, 2018

@heathdutton heathdutton added this to Code Review (2 required) in Mautic 2 Dec 6, 2018

@npracht npracht moved this from Code Review (2 required) to Ready to Test (first time) in Mautic 2 Jan 3, 2019

@alanhartless alanhartless added this to Needs Testing in 2.15.1 Jan 14, 2019

@alanhartless alanhartless moved this from Needs Testing to Needs Second Test in 2.15.1 Jan 30, 2019

@npracht npracht removed the Ready To Test label Feb 6, 2019

@alanhartless alanhartless removed this from Needs Second Test in 2.15.1 Mar 11, 2019

@alanhartless alanhartless modified the milestones: 2.15.1, 2.16.0 Mar 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.