Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Campaign stats improvement #6907

Merged
merged 9 commits into from Mar 11, 2019

Conversation

Projects
3 participants
@kuzmany
Copy link
Contributor

kuzmany commented Nov 20, 2018

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #6847
BC breaks?
Deprecations?

Description:

This PR should resolve inconsintent stats between graph and event data.
This PR take all event logs and making stats from them. For actions after condition we take data from parent condition for true/false.

image

Steps to reproduce the bug:

  1. Stats data are inconsistent in every detail. This data count stats from events execute with acutal contacts and don't count repeat events, manually removed contacts etc. Look to reported issue #6847

Steps to test this PR:

  1. Test random campaign with random stats and check if works properly

For example this campaigh with 3 contacts and few repeat actions and condition display 14 events for graph and 9 events for positive action and 5 events for negative action. That means 14 = 9+5 (correct)

image

@kuzmany kuzmany added Bug WIP labels Nov 20, 2018

kuzmany added some commits Nov 20, 2018

@npracht npracht modified the milestone: 2.15.1 Dec 3, 2018

@heathdutton heathdutton added this to Code Review (2 required) in Mautic 2 Dec 6, 2018

@npracht npracht moved this from Code Review (2 required) to Ready to Test (first time) in Mautic 2 Jan 3, 2019

@alanhartless alanhartless added this to Needs Testing in 2.15.1 Jan 14, 2019

@npracht

npracht approved these changes Feb 6, 2019

Copy link
Member

npracht left a comment

Tested in production environment for few weeks. It works better !

@npracht npracht moved this from Needs Testing to Needs Second Test in 2.15.1 Feb 6, 2019

@alanhartless alanhartless merged commit 5afda3b into mautic:staging Mar 11, 2019

2 checks passed

Scrutinizer Analysis: 1 updated code elements – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Mautic 2 automation moved this from Ready to Test (first time) to Merged Mar 11, 2019

@alanhartless alanhartless moved this from Needs Second Test to Merged in 2.15.1 Mar 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.