Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for non Outlook condition in email builder #6938

Merged
merged 4 commits into from Dec 5, 2018

Conversation

Projects
4 participants
@kuzmany
Copy link
Contributor

kuzmany commented Nov 29, 2018

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

Non outlook condition are not translated correctly.
More https://stackoverflow.com/questions/5982364/is-there-a-html-conditional-statement-for-everything-not-outlook

Steps to reproduce the bug:

  1. Add test blank test template blank-test.zip
  2. Create email with that template and save
  3. Check the source code of preview email and <mcomment /> tag

image

Steps to test this PR:

  1. Load up this PR
  2. Repeat all steps and then check email source doe, you will see the correct condition

image

kuzmany added some commits Nov 29, 2018

@kuzmany kuzmany added this to the 2.15.1 milestone Nov 29, 2018

@Woeler Woeler modified the milestones: 2.15.1, 2.15.0 Nov 29, 2018

@Woeler Woeler added this to To do in Testing 2.15.0 Nov 29, 2018

@Woeler Woeler modified the milestones: 2.15.0, 2.15.1 Dec 3, 2018

@Woeler Woeler removed this from To do in Testing 2.15.0 Dec 3, 2018

@johbuch

johbuch approved these changes Dec 3, 2018

Copy link

johbuch left a comment

it works

@npracht npracht modified the milestone: 2.15.1 Dec 3, 2018

@kuzmany kuzmany modified the milestones: 2.15.1, 2.15.0 Dec 4, 2018

@kuzmany kuzmany added this to Tested once in Testing 2.15.0 Dec 4, 2018

@Woeler Woeler merged commit b13c075 into mautic:staging Dec 5, 2018

2 checks passed

Scrutinizer Analysis: No new issues – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Testing 2.15.0 automation moved this from Tested once to Merged Dec 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.