Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow devs extend campaign events restricitons #6970

Open
wants to merge 5 commits into
base: staging
from

Conversation

2 participants
@kuzmany
Copy link
Contributor

kuzmany commented Dec 5, 2018

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

In our project we create custom send email campaign action.
But we cannot add decision (opens, clicks, reply) to our custom send email action.
This PR added option to devs add restrictions to any decision/action/condition.

This is our usage in plugin

image

Steps to test this PR:

  1. Just code review from devs hope enough

kuzmany added some commits Dec 5, 2018

@kuzmany kuzmany added Ready To Test and removed WIP labels Dec 5, 2018

@kuzmany kuzmany added this to the 2.15.1 milestone Dec 5, 2018

@kuzmany kuzmany changed the title New AllowedEventTypeDecisionEvent Allow devs extend campaign events restricitons Dec 5, 2018

kuzmany added some commits Dec 6, 2018

@heathdutton heathdutton added this to Code Review (2 required) in Mautic 2 Dec 6, 2018

@npracht npracht moved this from Code Review (2 required) to Ready to Test (first time) in Mautic 2 Jan 3, 2019

@alanhartless alanhartless added this to Needs Testing in 2.15.1 Jan 14, 2019

@alanhartless

This comment has been minimized.

Copy link
Contributor

alanhartless commented Jan 30, 2019

@kuzmany This is already supported via the target array when defining the event. Marketing messages make use of this in order to allow email decision opens, replies, etc to connect into the send marketing message action.

'connectionRestrictions' => [
                'target' => [
                    'decision' => ['email.open', 'email.reply', 'email.click'], 
                ],
            ],

@alanhartless alanhartless moved this from Needs Testing to Discussion in 2.15.1 Jan 30, 2019

@alanhartless alanhartless removed this from Discussion in 2.15.1 Mar 11, 2019

@alanhartless alanhartless removed this from the 2.15.1 milestone Mar 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.