Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error: Got a packet bigger than 'max_allowed_packet' bytes #6973

Merged
merged 1 commit into from Jan 30, 2019

Conversation

Projects
2 participants
@kuzmany
Copy link
Contributor

kuzmany commented Dec 6, 2018

…llowed_packet'

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

We had issue If large campaign (hundred thousands contacts) want to remove contacts from campaign. The query contains in statement with all contact IDs. I notice, that countID not allow limiter to that query https://github.com/mautic/mautic/pull/6973/files#diff-a40153b383e4af2f8e5ae77a534a264aR509

image

'SQLSTATE[08S01]: Communication link failure: 1153 Got a packet bigger than 'max_allowed_packet' bytes'

Steps to test this PR:

  1. Large segment added to campaign
  2. Rebuild campaign membership
  3. Then change segment source in campaign
  4. See error in logs

@kuzmany kuzmany added this to the 2.15.1 milestone Dec 6, 2018

@kuzmany

This comment has been minimized.

Copy link
Contributor Author

kuzmany commented Dec 6, 2018

@alanhartless Can you look on it? This make a lot of mess, a lot of GB of logs etc :(

@alanhartless

This comment has been minimized.

Copy link
Contributor

alanhartless commented Dec 6, 2018

Looks right from a code perspective.

@heathdutton heathdutton added this to Code Review (2 required) in Mautic 2 Dec 6, 2018

@npracht npracht moved this from Code Review (2 required) to Ready to Test (first time) in Mautic 2 Jan 3, 2019

@alanhartless alanhartless added this to Needs Testing in 2.15.1 Jan 14, 2019

@alanhartless

This comment has been minimized.

Copy link
Contributor

alanhartless commented Jan 30, 2019

Merging this as tested since @heathdutton had the same fix in #7139.

@alanhartless alanhartless merged commit c640466 into mautic:staging Jan 30, 2019

2 checks passed

Scrutinizer Analysis: No new issues – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Mautic 2 automation moved this from Ready to Test (first time) to Merged Jan 30, 2019

@alanhartless alanhartless moved this from Needs Testing to Merged in 2.15.1 Jan 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.