Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added relative date support to anniversary/birthday #6993

Merged
merged 7 commits into from Jan 15, 2019

Conversation

Projects
3 participants
@kuzmany
Copy link
Contributor

kuzmany commented Dec 11, 2018

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL mautic/documentation#299
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

This update bring support relative dates to anniversary.
At the moment (https://www.mautic.org/docs/en/contacts/manage_segments.html) we can use anniversary for date filter. This update allow use anniversary with relative dates. For example:

  • anniversary -7 days
  • anniversary -1 month
  • anniversary +3 days
  • birthday +1 month
  • birthday -14 days

etc.

Steps to test this PR:

  1. Load up this PR
  2. Create date contact custom field
  3. Setup this field with date to anniversary with -7 days
    For example: If today is 11. 12. 2018 setup this field for 4. 12. 2010
  4. Create segment with this custom field filter and add equals and value of filter: anniversary -7 days
  5. Your contact should be added to segment
  6. If you change contacts custom field value to 3. 12. 2010, contact should be removed from segment.

@kuzmany kuzmany added this to the 2.15.1 milestone Dec 11, 2018

@kuzmany kuzmany added WIP and removed Ready To Test labels Dec 11, 2018

kuzmany added some commits Dec 11, 2018

@kuzmany kuzmany changed the title Added relative date support to anniversary Added relative date support to anniversary/birthday Dec 11, 2018

@kuzmany kuzmany added Ready To Test and removed WIP labels Dec 11, 2018

@johbuch
Copy link

johbuch left a comment

tested on mautibox, it works, thanks

@heathdutton heathdutton added this to Code Review (2 required) in Mautic 2 Dec 12, 2018

@npracht npracht moved this from Code Review (2 required) to Ready to Test (confirmation) in Mautic 2 Jan 3, 2019

@alanhartless alanhartless added this to Needs Second Test in 2.15.1 Jan 14, 2019

Mautic 2 automation moved this from Ready to Test (confirmation) to Ready to Test (first time) Jan 15, 2019

@alanhartless alanhartless merged commit 6658083 into mautic:staging Jan 15, 2019

2 checks passed

Scrutinizer Analysis: 1 new issues – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Mautic 2 automation moved this from Ready to Test (first time) to Merged Jan 15, 2019

@alanhartless alanhartless moved this from Needs Second Test to Discussion in 2.15.1 Jan 15, 2019

@alanhartless alanhartless moved this from Discussion to Merged in 2.15.1 Jan 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.