Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Fixes to preferences center #7006
Please be sure you are submitting this against the staging branch.
Preferences center did a lot of strange things. I don't remember which PR mess it, but it was during this code was changes https://github.com/kuzmany/mautic/blob/ef5c590baba41133371f9a53b76e3e7caeb3f257/app/bundles/LeadBundle/Form/Type/ContactFrequencyType.php#L53-L53
I noticed several issues:
Enabled preferences center - use default center (not landing page)
Enabled preferences center - use landing page as prefs center
Steps to reproduce the bug:
Steps to test this PR:
referenced this pull request
Dec 31, 2018
moved this from Ready to Test (confirmation)
to Code Review (2 required)
in Mautic 2
Jan 3, 2019
Yes, that's not right. If you turn off PC elements on the email settings page, it breaks any existing custom PCs and causes them to display Symfony errors for those controls. That's definitely not right, because there may already be emails out in the world at the time.
When using a custom preference center, its configuration should trump that set under email settings. Email settings should only control the default generated PC.
You guys are making me want to learn Symfony & Twist. Cool tech.
Darn, I missed the point about applying this against the "staging" branch.
I'm hoping 2.15.1 gets released soon! Can't wait for this fix to become fully available. Thanks again kuzmany!
Actually, it works against 2.15.0 as well. It turns out I had missed one ending bracket in the code I had copied from the diff. Awesome!
Looks good. A few minor issues:
cStuartHardwick left a comment •
Current bugs resolved. There are some other issues that ought to be addressed, but these are not breaking changes:
To be clear, I consider this a very minor thing with an easy work around and would really prefer it not hold up 2.15.1--but I don't want you to think it's fixed, either.
Jan 30, 2019
In theory, you can download any branch from Git, and install on your site (and deal with potential merge issues later). I don't really see that as practical though, personally, even through I work in IT (in different technologies). There are databases changes as well as code changes, and the potential for things going wrong (or at least becoming a huge time sink) is large.
I too would dearly leave to give my subscribers a working preference center (which they have been complaining about) but see to practical way forward except to wait.