Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix International phone number validation message #7010

Merged
merged 4 commits into from Dec 14, 2018

Conversation

Projects
3 participants
@kuzmany
Copy link
Contributor

kuzmany commented Dec 14, 2018

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #7002
BC breaks?
Deprecations?

Description:

Fix for 2.15.0 beta for #7002

Steps to reproduce the bug:

Steps to test this PR:

  1. Load up this PR
  2. Test phone valadtion (required, international phone number format with default and custom message)

List deprecations along with the new alternative:

List backwards compatibility breaks:

@kuzmany kuzmany added Bug WIP labels Dec 14, 2018

@Woeler Woeler added this to the 2.15.0 milestone Dec 14, 2018

@npracht
Copy link
Member

npracht left a comment

Without the validation and without text, the default is shown.
Without the format validation and with custom text it works.
With the validation and without text, the default is shown.
With the validation and with text, the custom is shown.


Just one comment, why is there a mandatory star (red) here:
capture d ecran 2018-12-14 a 13 57 07

Because the field is not mandatory, can you remove it ?

@npracht

This comment has been minimized.

Copy link
Member

npracht commented Dec 14, 2018

@Woeler if you can have a quick look at the code, then we can add it ;)

@Woeler
Copy link
Member

Woeler left a comment

Tested and works. Thanks.

@kuzmany kuzmany dismissed stale reviews from Woeler and npracht via c8b879d Dec 14, 2018

@kuzmany

This comment has been minimized.

Copy link
Contributor Author

kuzmany commented Dec 14, 2018

@npracht good point, required flag removed

@npracht

This comment has been minimized.

Copy link
Member

npracht commented Dec 14, 2018

Then it is ready to commit

@Woeler Woeler removed the Ready To Commit label Dec 14, 2018

@Woeler Woeler merged commit 8be7bea into mautic:staging Dec 14, 2018

2 checks passed

Scrutinizer Analysis: No new issues – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Testing 2.15.0 automation moved this from Ready to commit to Merged Dec 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.