Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix object in segment filter #7019

Merged
merged 1 commit into from Jan 15, 2019

Conversation

Projects
3 participants
@kuzmany
Copy link
Contributor

kuzmany commented Dec 17, 2018

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

If we extend segments filter by plugin, some notice error on dispatcher

  
   LeadEvents::LIST_FILTERS_CHOICES_ON_GENERATE => [
                ['onListFiltersGenerate', 0],
            ],

Then use owne group/object (event)

$event->addChoice('event', 'event_date', $config);

This return notice and this PR fixed it.

Steps to test this PR:

  1. Load up this PR
  2. Just code review should be enought

@kuzmany kuzmany added this to the 2.15.1 milestone Dec 17, 2018

@heathdutton
Copy link
Member

heathdutton left a comment

Looks good to me.

@kuzmany kuzmany added this to Ready to Test (confirmation) in Mautic 2 Dec 27, 2018

@alanhartless alanhartless added this to Needs Second Test in 2.15.1 Jan 14, 2019

Mautic 2 automation moved this from Ready to Test (confirmation) to Ready to Test (first time) Jan 15, 2019

@alanhartless alanhartless merged commit 2ab290d into mautic:staging Jan 15, 2019

2 checks passed

Scrutinizer Analysis: No new issues – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Mautic 2 automation moved this from Ready to Test (first time) to Merged Jan 15, 2019

@alanhartless alanhartless moved this from Needs Second Test to Discussion in 2.15.1 Jan 15, 2019

@alanhartless alanhartless moved this from Discussion to Merged in 2.15.1 Jan 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.