Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to multiselect in ContactSegmentFilterCrate #7023

Closed
wants to merge 3 commits into
base: staging
from

Conversation

Projects
None yet
4 participants
@kuzmany
Copy link
Contributor

kuzmany commented Dec 18, 2018

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

This PR fix multiselect segment filter.

Steps to reproduce the bug:

  1. Create multiselect custom contact field
  2. Add to contact one of value of new multiselect custom contact field
  3. Create segment with this custom multiselect field
    4: Run segmetns rebuild command
    5: See none of contact was assigned to segment

Steps to tests

  1. Repeat all steps
  2. Contacts should be added to segment after run segment rebuild command

@kuzmany kuzmany added this to the 2.15.1 milestone Dec 18, 2018

@kuzmany

This comment has been minimized.

Copy link
Contributor Author

kuzmany commented Dec 20, 2018

@Maxell92 as author segments refactoring PR, could you look on it?

@Maxell92

This comment has been minimized.

Copy link
Contributor

Maxell92 commented Dec 23, 2018

@kuzmany I think this is not a correct solution - your PR broke tests.
What is the purpose of this change?

@kuzmany

This comment has been minimized.

Copy link
Contributor Author

kuzmany commented Dec 25, 2018

@Maxell92 I've noticed multiselect doesn't work also with custom multiselect field.
I am going to add more description and fix unit tests

kuzmany added some commits Dec 25, 2018

@Maxell92

This comment has been minimized.

Copy link
Contributor

Maxell92 commented Dec 25, 2018

I tested this PR and it seems ok. Still a little bit nervous from changes in the tests and from failing one but I could not find any problematic case. Needs pretty careful tests however.

@johbuch

This comment has been minimized.

Copy link

johbuch commented Dec 28, 2018

tested this one on mautibox but contacts did not enter my different segments that have filter on a multiselect custom field so not sure it works

@Enc3phale

This comment has been minimized.

Copy link
Contributor

Enc3phale commented Dec 28, 2018

Can't reproduce the bug on a 2.15, It works without this PR.

@npracht npracht added this to Ready to Test (first time) in Mautic 2 Jan 3, 2019

@kuzmany

This comment has been minimized.

Copy link
Contributor Author

kuzmany commented Jan 9, 2019

Closed due some new tests with my plugin and works properly without PR.
Maybe something with my custom decorator

@kuzmany kuzmany closed this Jan 9, 2019

@kuzmany kuzmany removed this from Ready to Test (first time) in Mautic 2 Jan 9, 2019

@kuzmany kuzmany removed this from the 2.15.1 milestone Jan 9, 2019

@kuzmany kuzmany added Backlog and removed Bug Ready To Test labels Jan 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.