Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report CSV export with enclosures #7049

Merged
merged 6 commits into from Jan 15, 2019

Conversation

Projects
3 participants
@kuzmany
Copy link
Contributor

kuzmany commented Dec 24, 2018

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

Some clients required exports with empty columns with enclosures.
This PR add support for it as option in Configuration > Report Settings tab.

image

Old format:

Firstname, "some text",,Lastname

New format:

"Firstname","some test","","Lastname"

Steps to test this PR:

  1. Load up this PR
  2. Try CSV export contacts with some contacts etc.
  3. Should works like before
  4. Enable Always enclose data in CSV export in Configurations > Report Settings tab
  5. Export CSV report
  6. See all fields are enclosures, even empty fields

@kuzmany kuzmany added this to the 2.15.1 milestone Dec 24, 2018

kuzmany added some commits Dec 24, 2018

@johbuch
Copy link

johbuch left a comment

it works ;)

@kuzmany

This comment has been minimized.

Copy link
Contributor Author

kuzmany commented Dec 26, 2018

@johbuch as you request, new option in configuration. Please re-test

@johbuch
Copy link

johbuch left a comment

tested on mautibox, it works

@kuzmany kuzmany added this to Ready to Test (first time) in Mautic 2 Dec 27, 2018

@npracht npracht moved this from Ready to Test (first time) to Ready to Test (confirmation) in Mautic 2 Jan 3, 2019

@alanhartless alanhartless added this to Needs Second Test in 2.15.1 Jan 14, 2019

Update messages.ini
Updated translation

Mautic 2 automation moved this from Ready to Test (confirmation) to Changes Requested / Review Jan 15, 2019

Mautic 2 automation moved this from Changes Requested / Review to Ready to Test (first time) Jan 15, 2019

@alanhartless alanhartless merged commit 72b8c5c into mautic:staging Jan 15, 2019

0 of 2 checks passed

Scrutinizer Created
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

Mautic 2 automation moved this from Ready to Test (first time) to Merged Jan 15, 2019

@alanhartless alanhartless moved this from Needs Second Test to Merged in 2.15.1 Jan 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.