Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect default_timezone configuration for dates during segment rebuild #7097

Merged
merged 5 commits into from Jan 30, 2019

Conversation

Projects
3 participants
@kuzmany
Copy link
Contributor

kuzmany commented Jan 3, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #7033
BC breaks?
Deprecations?

Description:

Noticed (#7033) segments filter doesn't respect default timezone from configuration. This PR added support for it

Steps to test this PR:

  1. Load up this PR
  2. It's little hard to explain to non tech people.
  3. But you have to test on different timezones changed in configuration and check if filters work differently. Also you can check the logs of segment filter queries in System info.

@kuzmany kuzmany added this to the 2.15.1 milestone Jan 3, 2019

@npracht npracht added this to Ready to Test (first time) in Mautic 2 Jan 3, 2019

@kuzmany kuzmany referenced this pull request Jan 3, 2019

Closed

timezone issue #7033

@luizeof

This comment has been minimized.

Copy link

luizeof commented Jan 3, 2019

Great!

@alanhartless alanhartless added this to Needs Testing in 2.15.1 Jan 14, 2019

kuzmany added some commits Jan 24, 2019

@alanhartless alanhartless merged commit 18d5562 into mautic:staging Jan 30, 2019

2 checks passed

Scrutinizer Analysis: 1 new issues, 1 updated code elements – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Mautic 2 automation moved this from Ready to Test (first time) to Merged Jan 30, 2019

@alanhartless alanhartless moved this from Needs Testing to Merged in 2.15.1 Jan 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.