Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch not found cache item #7102

Merged
merged 5 commits into from May 8, 2019

Conversation

Projects
5 participants
@escopecz
Copy link
Member

commented Jan 4, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix? Y
New feature? N
Automated tests included? Y
Related user documentation PR URL /
Related developer documentation PR URL /
Issues addressed (#s or URLs) mautic-inc/mautic-internal#1181
BC breaks? N
Deprecations? N

Description:

If a cached request is not found the CacheStorageHelper is returning false which later resulted in an uncaught exception. This PR is handling this scenario and it will log valuable error in the logs.

This is the error message this PR is solving:

Type error: Argument 2 passed to Symfony\Component\HttpFoundation\Request::__construct() must be of the type array, boolean given

Steps to reproduce the bug:

  1. We are not sure how to reproduce as we do not know how the cached request can be missing and have the key for it in the same time. The theory we want to confirm is that it's being stored by different cache adaptor. The new error message will make this clear.

Steps to test this PR:

  1. Make sure Momentum webhooks still work.

Woeler and others added some commits Dec 19, 2018

@escopecz escopecz added this to the 2.15.1 milestone Jan 4, 2019

@kuzmany

This comment has been minimized.

Copy link
Contributor

commented Jan 8, 2019

Some tests failing. Fix travis

@alanhartless alanhartless added this to Has Conflicts and/or Failing Tests in 2.15.1 Jan 14, 2019

@escopecz escopecz moved this from Has Conflicts and/or Failing Tests to Needs Testing in 2.15.1 Jan 31, 2019

@alanhartless alanhartless modified the milestones: 2.15.1, 2.16.0 Mar 11, 2019

@alanhartless alanhartless removed this from Needs Testing in 2.15.1 Mar 11, 2019

@npracht npracht modified the milestones: 2.16.0, 2.15.2 Mar 28, 2019

@npracht npracht added this to Ready to Test (first time) in Mautic 2 Apr 4, 2019

@kuzmany

kuzmany approved these changes May 8, 2019

@kuzmany kuzmany merged commit a348495 into mautic:staging May 8, 2019

2 checks passed

Scrutinizer Analysis: 5 new issues, 5 updated code elements – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Mautic 2 automation moved this from Ready to Test (first time) to Merged May 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.