Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dispatcher to ContactSegmentFilterDictionary #7124

Closed
wants to merge 5 commits into
base: staging
from

Conversation

Projects
None yet
2 participants
@kuzmany
Copy link
Contributor

kuzmany commented Jan 11, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

This PR added option to add listener to ContactSegmentFilterDictionary.
Useful If you're using your own filters in segment builder.

Steps to test this PR:

  1. Load up this PR
  2. Hope just code review is enough. Otherwise devs should try create EventListener for LeadEvents::LIST_FILTERS_DICTIONARY_GENERATED and extend translation by addTranslation

@kuzmany kuzmany added this to the 2.15.1 milestone Jan 11, 2019

kuzmany added some commits Jan 11, 2019

@kuzmany kuzmany added WIP and removed Ready To Test labels Jan 13, 2019

@alanhartless alanhartless modified the milestones: 2.15.1, 2.16.0 Jan 14, 2019

@kuzmany kuzmany removed the WIP label Jan 15, 2019

@kuzmany

This comment has been minimized.

Copy link
Contributor Author

kuzmany commented Jan 15, 2019

Closed
Due ServiceCircularReferenceException with call event_dispatcher in __construct.
We created or own Decorator with extend dictionary by class

@kuzmany kuzmany closed this Jan 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.