Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scheduled jump to event campaign action #7129

Open
wants to merge 10 commits into
base: staging
from

Conversation

2 participants
@kuzmany
Copy link
Contributor

kuzmany commented Jan 14, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

I've notice to issues with Jump to event campaign actions:

1, Contact Ids for scheduled campaign action are not load properly because this line https://github.com/mautic/mautic/pull/7129/files#diff-446760f223392e6d37ebd6f1580d27c9R108

$campaignEvent->getContacts()
load contacts but keys are event ids, but later need contact ids as key https://github.com/kuzmany/mautic/blob/b6edbb4489ea51dfa0c3cd1a57361da4337c98de/app/bundles/CampaignBundle/Executioner/Logger/EventLogger.php#L215-L215

2, Also jump to event action don't recalculate rotation ID with this error:

Integrity constraint violation: 1062 Duplicate entry '37-13447-3' for key 'campaign_rotation'

You can use test campaign

image

Steps to reproduce the bug:

  1. Test schedule campaign action jump to event
  2. Test campaign from screenshot above
  3. Should return error

Steps to test this PR:

  1. Load up this PR
  2. test schedule camapign action jump to event

@kuzmany kuzmany added Bug WIP labels Jan 14, 2019

@kuzmany kuzmany added this to the 2.15.1 milestone Jan 14, 2019

@kuzmany kuzmany added Ready To Test and removed WIP labels Jan 14, 2019

kuzmany added some commits Jan 14, 2019

@alanhartless alanhartless added this to Needs Testing in 2.15.1 Jan 14, 2019

kuzmany added some commits Jan 14, 2019

@alanhartless alanhartless added this to Changes Requested / Review in Mautic 2 via automation Jan 30, 2019

@@ -190,6 +191,16 @@ public function executeForContacts(Event $event, ArrayCollection $contacts, Coun
}
$config = $this->collector->getEventConfig($event);
static $jump;

This comment has been minimized.

@alanhartless

alanhartless Jan 30, 2019

Contributor

I still need to test this but a note. Let's not use a static in a method. PHP will keep that static across all instantiation of objects which can make testing a nightmare when you're trying to hunt down why they are getting unexpected results. Use a class property instead.

@alanhartless alanhartless modified the milestones: 2.15.1, 2.16.0 Mar 11, 2019

@alanhartless alanhartless removed this from Needs Testing in 2.15.1 Mar 11, 2019

@alanhartless

This comment has been minimized.

Copy link
Contributor

alanhartless commented Mar 11, 2019

Wasn't double tested before the 2.15.1 PR merge deadline so pushing to the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.