Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip international phone number validation if phone number is empty #7130

Merged
merged 3 commits into from Jan 29, 2019

Conversation

Projects
2 participants
@kuzmany
Copy link
Contributor

kuzmany commented Jan 14, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix? Yes
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #7107
BC breaks?
Deprecations?

Description:

Don't validate as international phone number in form If phone number is empty.

Steps to reproduce the bug:

  1. Add form with Phone field
  2. Set up Required to Off
  3. Set up Validate as international format to On
  4. Submit a form without phone number

Steps to test this PR:

  1. Load up this PR
  2. Repeat all steps

@kuzmany kuzmany added this to the 2.15.1 milestone Jan 14, 2019

@kuzmany

This comment has been minimized.

Copy link
Contributor Author

kuzmany commented Jan 16, 2019

Approve from comment: #7107 (comment)

@kuzmany kuzmany moved this from Needs Testing to Needs Second Test in 2.15.1 Jan 16, 2019

@alanhartless alanhartless added this to Ready to Test (first time) in Mautic 2 via automation Jan 29, 2019

@alanhartless alanhartless merged commit 409a65b into mautic:staging Jan 29, 2019

2 checks passed

Scrutinizer Analysis: 1 new issues – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Mautic 2 automation moved this from Ready to Test (first time) to Merged Jan 29, 2019

@alanhartless alanhartless moved this from Needs Second Test to Merged in 2.15.1 Jan 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.