Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with regex with underscore in URL #7169

Merged
merged 3 commits into from Mar 11, 2019

Conversation

Projects
4 participants
@kuzmany
Copy link
Contributor

kuzmany commented Jan 24, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

This PR fixed error:

Warning: preg_match_all(): Unknown modifier '\'

More https://stackoverflow.com/questions/47185669/preg-match-all-unknown-modifier

Steps to reproduce the bug:

  1. Create email
  2. Create link https://domain.tld/some-alias_t#_ga=2.2dd
  3. Send email
  4. Should return error above (check logs)

Steps to test this PR:

  1. Load up this PR
  2. Repeat all steps
  3. Should works now

@kuzmany kuzmany added Bug WIP Ready To Test and removed WIP labels Jan 24, 2019

kuzmany added some commits Jan 24, 2019

@kuzmany kuzmany changed the title Fix issue with regex If URL has underscore Fix issue with regex with underscore in URL Jan 24, 2019

@kuzmany kuzmany added this to the 2.15.1 milestone Jan 24, 2019

@alanhartless alanhartless added this to Needs Testing in 2.15.1 Jan 31, 2019

@npracht

npracht approved these changes Mar 8, 2019

Copy link
Member

npracht left a comment

👍

@npracht npracht added this to Ready to Test (first time) in Mautic 2 via automation Mar 8, 2019

@kuzmany

This comment has been minimized.

Copy link
Contributor Author

kuzmany commented Mar 8, 2019

This bugfix is used on production server.
@indorock Can you approve it?

@escopecz escopecz moved this from Needs Testing to Needs Second Test in 2.15.1 Mar 8, 2019

@alanhartless alanhartless merged commit 0f58765 into mautic:staging Mar 11, 2019

2 checks passed

Scrutinizer Analysis: No new issues – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Mautic 2 automation moved this from Ready to Test (first time) to Merged Mar 11, 2019

@alanhartless alanhartless moved this from Needs Second Test to Merged in 2.15.1 Mar 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.