Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove object filtering within alias generator #7210

Merged
merged 2 commits into from Mar 11, 2020

Conversation

@Enc3phale
Copy link
Contributor

Enc3phale commented Feb 4, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix? Y
New feature? N
Automated tests included? N
Related user documentation PR URL N
Related developer documentation PR URL N
Issues addressed (#s or URLs) N
BC breaks? N
Deprecations? N

Description:

The custom field alias is not unique when you leave alias field empty because the validator/generator makes the difference between an alias for a custom company field or a custom contact field.

Exemple of bug: when you launch contact .csv import, only the alias is taken into account for fields mapping, it does not matter if the field is a company type or a contact type. So the company field always erased the contact field if they have the same alias.

Steps to reproduce the bug:

  1. Create a contact custom field with label Custom field leave alias blank
  2. Create a company custom field with label Custom field leave alias blank
  3. Two field with the same alias is now present

Steps to test this PR:

  1. Load up this PR
  2. Remove previous company field with custom label Custom field
  3. Try to recreate the same, now the validator rename alias as expected custom_field1
@Enc3phale Enc3phale changed the title Remove filtering by object Remove object filtering within alias genereator Feb 4, 2019
@Enc3phale Enc3phale changed the title Remove object filtering within alias genereator Remove object filtering within alias generator Feb 4, 2019
Copy link
Member

npracht left a comment

works and avoid issues on import

@alanhartless alanhartless added this to the 2.15.1 milestone Feb 6, 2019
@alanhartless alanhartless modified the milestones: 2.15.1, 2.16.0 Mar 12, 2019
@npracht npracht modified the milestones: 2.16.0, 2.15.2 Mar 28, 2019
@npracht npracht added this to Ready to Test (confirmation) in Mautic 2 Apr 4, 2019
@npracht

This comment has been minimized.

Copy link
Member

npracht commented May 3, 2019

Using in production environment.

Mautic 2 automation moved this from Ready to Test (confirmation) to Ready to Test (first time) May 3, 2019
@kuzmany
kuzmany approved these changes May 3, 2019
Mautic 2 automation moved this from Ready to Test (first time) to Changes Requested / Review May 3, 2019
@kuzmany kuzmany modified the milestones: 2.15.2, 2.16.0 May 19, 2019
@kuzmany

This comment has been minimized.

Copy link
Contributor

kuzmany commented May 19, 2019

Not feedback.
Moved to next release.

@npracht npracht requested a review from kuzmany Jul 2, 2019
@npracht
npracht approved these changes Jul 2, 2019
Copy link
Member

npracht left a comment

👍

@npracht npracht moved this from Changes Requested / Review to Ready to Test (confirmation) in Mautic 2 Aug 15, 2019
Copy link
Member

RCheesley left a comment

Confirm that pre-test the fields used the same alias, and post-patch they are unique fieldnames.

Tested sending an email using the two fields and it worked as expected.

@npracht npracht modified the milestone: 2.16.0 Jan 23, 2020
@RCheesley RCheesley added this to the 2.16.1 milestone Mar 9, 2020
@escopecz escopecz added this to Ready to Commit (passed testing) in Mautic 2 Mar 10, 2020
@RCheesley RCheesley dismissed kuzmany’s stale review Mar 10, 2020

Code has been updated

@dennisameling dennisameling merged commit 1ca632f into mautic:staging Mar 11, 2020
2 checks passed
2 checks passed
Scrutinizer Analysis: No new issues – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Mautic 2 automation moved this from Ready to Commit (passed testing) to Merged Mar 11, 2020
@mautibot

This comment has been minimized.

Copy link

mautibot commented Mar 20, 2020

This pull request has been mentioned on Mautic Community Forums. There might be relevant details there:

https://forum.mautic.org/t/announcing-mautic-2-16-1-beta/13438/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Mautic 2
  
Merged
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
You can’t perform that action at this time.