Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Real-time campaign events triggering #7213

Open
wants to merge 6 commits into
base: staging
from

Conversation

Projects
None yet
4 participants
@kuzmany
Copy link
Contributor

kuzmany commented Feb 4, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

  • add migrations

This PR allow trigger events immediately after contact is added to campaign.

image

Steps to test this PR:

  1. Load up this PR.
    If use own test enviroment run php app/console doctrine:migrations:migrate
  2. Create campaign with some events (actions/conditions) and enable option Trigger event's realtime
  3. Add contact to campaign
  4. See If events are triggered immediately after contact was added to campaign
  5. Then disable option. Add another contact to campaigna and see If events are not triggered immediately. I would by wait for cron

@kuzmany kuzmany changed the title Realtime trigger campaign event Real-time campaign events triggering Feb 4, 2019

@kuzmany kuzmany added Ready To Test and removed WIP labels Feb 4, 2019

kuzmany added some commits Feb 4, 2019

@indorock
Copy link

indorock left a comment

looks good

@indorock
Copy link

indorock left a comment

looks good

@alanhartless

This comment has been minimized.

Copy link
Contributor

alanhartless commented Feb 6, 2019

What is the use case for this?

What happens if your cron jobs to build the campaign membership overlap your cron job to execute the campaign?

@indorock

This comment has been minimized.

Copy link

indorock commented Feb 13, 2019

@alanhartless we have implemented Mautic with the goal of handling all user-directed emails, including system emails like email verify and password reset emails. Currently even with our cronjob set up at tight intervals, it still takes upwards of 5-10 minutes for one of these emails to reach the user. So we asked @kuzmany to come up with a solution that would fire an email instantly, not reliant on waiting for the email cron job to run.

Regarding your second question, he informed me that it would behave as normal. His words:

It's the same workflow like mautic:campaign:trigger but this campaign is triggered for contact after add to campaign . But the code is the same, like If you wait to cron

@npracht npracht added this to the 2.16.0 milestone Feb 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.