Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix segment filters without object #7236

Open
wants to merge 1 commit into
base: staging
from

Conversation

2 participants
@kuzmany
Copy link
Contributor

kuzmany commented Feb 12, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

This PR resolve issue from PR #6946 which was reverted later #7168

Client instance with segment filters created in 2016-08-31 stop working and not displyed in filters correctly (empty operators selectbox...). In that time Mautic didn't support feature lead/company object.

image

I noticed that there due no object in filters columns:

image

This PR added default value to FieldFilterTransformer for that fix.
Then works properly

Steps to reproduce the bug:

  1. Hard to tell. You can try create segment with filter, and removed object from filters
  2. Then can seee similar issue like on screenshots above

Steps to test this PR:

  1. Load up this PR
  2. Try same like from steps to reproduce
    3: Filter should works properly

@kuzmany kuzmany added this to the 2.15.1 milestone Feb 12, 2019

@alanhartless alanhartless modified the milestones: 2.15.1, 2.16.0 Mar 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.