Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipedrive - fix with import empty values #7267

Merged
merged 2 commits into from Mar 11, 2019

Conversation

Projects
4 participants
@kuzmany
Copy link
Contributor

kuzmany commented Feb 19, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix? Y
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

Noticed issue with Pipedrive during import Lead/Company from Pipedrive to Mautic.

Steps to reproduce the bug:

  1. Setup Pipedrive with webhook https://www.mautic.org/docs/en/plugins/pipedrive.html
  2. Create contact on Pipedrive
  3. Check in Mautic
  4. Then try set empty some fields in Pipedrive mapped to Mautic.
  5. Fields with empty value wasn't update

Steps to test this PR:

  1. Load up this PR
  2. Repeat all steps
  3. The fields are empty now If you change reset it in Pipedrive

@kuzmany kuzmany added this to the 2.15.1 milestone Feb 19, 2019

@johbuch

This comment has been minimized.

Copy link

johbuch commented Feb 25, 2019

@kuzmany just tested but it does not work for me.
I created a company in pipedrive. This company was then created in mautic.
Then I empty some field (text, list etc.) but the values are still in the company within mautic

@kuzmany

This comment has been minimized.

Copy link
Contributor Author

kuzmany commented Feb 26, 2019

@johbuch I tested againg. And works for me, see screencast http://somup.com/cqnOQbn3Va
Also I tested it with custom field.
How did you test it?

@johbuch

This comment has been minimized.

Copy link

johbuch commented Feb 26, 2019

@kuzmany I just tested with the company address default field, it worked.
But for a custom field it does not work.
The custom field is updated, but not emptied when I delete the value in pipedrive.
You said, for a custom field it worked for you ?

@kuzmany

This comment has been minimized.

Copy link
Contributor Author

kuzmany commented Feb 26, 2019

@johbuch I will test again.

@kuzmany

This comment has been minimized.

Copy link
Contributor Author

kuzmany commented Mar 1, 2019

@johbuch Try now, It's fixed by last commit.

@johbuch

This comment has been minimized.

Copy link

johbuch commented Mar 4, 2019

@kuzmany thanks it works now
good job ;)

@npracht

npracht approved these changes Mar 5, 2019

Copy link
Member

npracht left a comment

Works properly

@npracht npracht added this to Ready to Test (first time) in Mautic 2 via automation Mar 5, 2019

@alanhartless alanhartless merged commit 617f8dd into mautic:staging Mar 11, 2019

2 checks passed

Scrutinizer Analysis: No new issues – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Mautic 2 automation moved this from Ready to Test (first time) to Merged Mar 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.