Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segments stats improvements #7285

Open
wants to merge 29 commits into
base: staging
from

Conversation

2 participants
@kuzmany
Copy link
Contributor

kuzmany commented Feb 26, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature? Enhancement
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

This PR bring large improvements to segment stats on details page.

New added/removed/total segment line graphs

With segment activity log added in 2.15 #6719 we are able to display added/removed/total contacts in time.
The main issue of this was figure out how to display data for segments created before that version.
We try identify it with with check first event log for segment and contact added before event log during the selected date range
https://github.com/mautic/mautic/pull/7285/files#diff-576fb4a56ed6ba56eef6267453efae7dR249
If we works in date range just with event logs we try display added/removed/total graph line, If not we display just added line.

image

Segment usage

This is helpful if we want identify usage of segment in another parts Mautic.
The number is clickable to IDs results of each controller.

image

Campaigns share tab

This help identify how many contacts of segments running in campaigns.
For example I can create segment woman and see the share of that segment in campaigns.

  • is ajaxify
  • is cached

image

Steps to test this PR:

  1. Load up this PR
  2. It's quite long story
  3. You need have larga data and segment
  4. Need test all stuff from description
  5. Especially take a look to line graph of segment. Segments with date range with data from event log and data without event log (after upgrade etc)

@kuzmany kuzmany added this to the 2.16.0 milestone Feb 26, 2019

@kuzmany kuzmany added WIP and removed Ready To Test labels Feb 26, 2019

@kuzmany kuzmany changed the title Segments stats improvements Segments stats improvements (in progress) Feb 26, 2019

kuzmany added some commits Feb 27, 2019

Add new line graphs to segment
added/removed/total

@kuzmany kuzmany added Ready To Test and removed WIP labels Mar 3, 2019

@kuzmany kuzmany changed the title Segments stats improvements (in progress) Segments stats improvements Mar 3, 2019

kuzmany added some commits Mar 3, 2019

Merge remote-tracking branch 'upstream/staging' into segments-stats-i…
…mprovements

# Conflicts:
#	app/bundles/LeadBundle/Model/ListModel.php
Merge remote-tracking branch 'upstream/staging' into segments-stats-i…
…mprovements

# Conflicts:
#	app/bundles/LeadBundle/Model/ListModel.php

@npracht npracht added this to Ready to Test (first time) in Mautic 2 via automation Mar 8, 2019

@npracht

npracht approved these changes Mar 8, 2019

Copy link
Member

npracht left a comment

Okay ! With last commits it works now. This is a greta improvement to follow the amount of contacts applying to some criteria (segment filters) in time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.