Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DNC enable/disable channel from Mautic prefs center #7303

Open
wants to merge 3 commits into
base: staging
from

Conversation

3 participants
@kuzmany
Copy link
Contributor

kuzmany commented Mar 6, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix? Y
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #7296
BC breaks?
Deprecations?

Description:

Noticed in 2.15 staging cannot remove DNC from Mautic for contact.
This PR fixed it

Steps to reproduce the bug:

  1. Go to contact profile
  2. Disable email channel from contact profile
  3. Then try enable it and see Do Not Contact label in profile

image

Steps to test this PR:

  1. Load up this PR
  2. Repeat steps and enable/disable channel from prefs center in Mautic should works properly

@kuzmany kuzmany added this to the 2.15.1 milestone Mar 6, 2019

@npracht

This comment has been minimized.

Copy link
Member

npracht commented Mar 6, 2019

@kuzmany doesn't work on mautibox. Should i test it somewhere else or it should be working there too ?

@kuzmany

This comment has been minimized.

Copy link
Contributor Author

kuzmany commented Mar 6, 2019

@npracht check now on mautibox

@npracht npracht added this to Ready to Test (first time) in Mautic 2 via automation Mar 6, 2019

@npracht

npracht approved these changes Mar 6, 2019

Copy link
Member

npracht left a comment

Great it works now.
@alanhartless this is quite critical, could you please review the code ? From a user perspective this is perfectly working.

@npracht npracht removed their assignment Mar 6, 2019

@alanhartless alanhartless modified the milestones: 2.15.1, 2.16.0 Mar 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.