Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add query string to the base URL for the pagination limit select as the pagination buttons does it #7309

Merged
merged 1 commit into from May 8, 2019

Conversation

Projects
4 participants
@escopecz
Copy link
Member

commented Mar 8, 2019

Q A
Bug fix? Y
New feature? N
Automated tests included? /
Related user documentation PR URL /
Related developer documentation PR URL /
Issues addressed (#s or URLs) /
BC breaks? N
Deprecations? N

Description:

When calling table pagination template with a query string like this:

    <div class="panel-footer">
        <?php echo $view->render(
            'MauticCoreBundle:Helper:pagination.html.php',
            [
                'totalItems'  => $itemCount,
                'page'        => $page,
                'limit'       => $limit,
                'baseUrl'     => $route,
                'queryString' => "&contactId={$contactId}",
                'sessionVar'  => 'an.item',
                'routeBase'   => RouteProvider::ROUTE_LIST,
            ]
        ); ?>
    </div>

It adds the queryString to the buttons (1, 2, 3, ...) (line 86), but it will not add it to the limit select URL. So both pagination actions goes to different URL.

This PR unifies the actions to be the same.

Steps to test this PR:

  1. Just code review and dis/agree with me

@alanhartless alanhartless added this to the 2.16.0 milestone Mar 12, 2019

@npracht npracht modified the milestones: 2.16.0, 2.15.2 Mar 28, 2019

@npracht npracht added this to Ready to Test (first time) in Mautic 2 Apr 4, 2019

@kuzmany

kuzmany approved these changes May 8, 2019

@kuzmany kuzmany merged commit aa81ce8 into mautic:staging May 8, 2019

2 checks passed

Scrutinizer Analysis: No new issues – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Mautic 2 automation moved this from Ready to Test (first time) to Merged May 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.