Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point email action improvements #7330

Open
wants to merge 21 commits into
base: staging
from

Conversation

Projects
None yet
1 participant
@kuzmany
Copy link
Contributor

kuzmany commented Mar 13, 2019

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs) #7320
BC breaks?
Deprecations?

Description:

This PR try figure out trigger points for each entity in points action reported in this issue #7320

  • added support for events system (eventName instead of callback, callback should be depraced and refactored in future)
  • added new column internal_id to point_lead_action_log table - ID or string - in thu future we can store URL for page hit and then we can run points action on each visits
  • added new option to email open point action - categories limit and execute one time/each email

image

Steps to test this PR:

  1. Load up this PR
  2. Create point actions - opens email type
  3. Test step by step with different point actions
  • Allow repeat the action - should change points everytime
  • Execute only: Once - should change points just one time
  • Execute only: For each email - should change points with every email ID - that means If I will create point action just for 3 emails, and all 3 emails my contact open , contact point score adjust point score each time
  1. Test also categories filter

List deprecations along with the new alternative:

  1. callback depraced on triggerAction
    'eventName' => EmailEvents::ON_POINT_CHANGE_ACTION_EXECUTED,

    Use eventName like in other parts of Mautic.

@kuzmany kuzmany added WIP and removed Ready To Test labels Mar 14, 2019

@kuzmany kuzmany changed the title Add option to execute points action for each ID Point email action improvements and added event based system Mar 18, 2019

kuzmany added some commits Mar 18, 2019

@kuzmany kuzmany removed the WIP label Mar 19, 2019

@kuzmany kuzmany changed the title Point email action improvements and added event based system Point email action improvements Mar 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.